Looks good. Thanks. I agree about the array failure. I mistakenly considered an OS X test in that diagnosis, but the test isn't failing anywhere on OS X.
> On Apr 19, 2016, at 10:35 PM, Xin Tong <xin_t...@apple.com> wrote: > > To summarize. I think I fixed the non-determinism in commit > 7d26a472009eae673fd40a0403ceb319027481be and re-enabled retain release code > motion (RRCM). > > I do not think the array test failure is related to RRCM , the benchmark > failed even after i disabled RRCM. > > https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/4240/ > <https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/4240/> > https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-15_10/4351/ > <https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-15_10/4351/> > > -Xin > >> On Apr 19, 2016, at 10:05 PM, Xin Tong <xin_t...@apple.com >> <mailto:xin_t...@apple.com>> wrote: >> >> >>> On Apr 19, 2016, at 10:03 PM, Xin Tong via swift-dev <swift-dev@swift.org >>> <mailto:swift-dev@swift.org>> wrote: >>> >>> >>>> On Apr 19, 2016, at 10:00 PM, Greg Parker <gpar...@apple.com >>>> <mailto:gpar...@apple.com>> wrote: >>>> >>>> Disabling the pass that way may have caused two more SILOptimizer test >>>> failures: >>>> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-15_10/4351/ >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-15_10/4351/> >>> I am fixing the problem now. >>>> >>>> I also suspect that the ArrayTraps failure is caused by something in the >>>> RR motion branch, but I'm still working to confirm that. >>> >>> I do not think so. >>> >>> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/4240/ >>> <https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/4240/> >> I meant if you look into the console output, the array test is still failing >> with RRcodemotion disabled. >>> >>> -Xin >>> >>>> >>>> >>>>> On Apr 19, 2016, at 9:45 PM, Xin Tong <xin_t...@apple.com >>>>> <mailto:xin_t...@apple.com>> wrote: >>>>> >>>>> Done in commit c2e8c81227263c9947f0ee0b8f9f6689d5e7bd21 , I have some >>>>> commit on top of this one, so reverting is not very easy. >>>>> -Xin >>>>> >>>>>> On Apr 19, 2016, at 9:40 PM, Greg Parker <gpar...@apple.com >>>>>> <mailto:gpar...@apple.com>> wrote: >>>>>> >>>>>> Thanks. I'll try that. >>>>>> >>>>>> >>>>>>> On Apr 19, 2016, at 9:35 PM, Xin Tong <xin_t...@apple.com >>>>>>> <mailto:xin_t...@apple.com>> wrote: >>>>>>> >>>>>>> I will check in something to disable the pass. >>>>>>> >>>>>>> -Xin >>>>>>> >>>>>>> >>>>>>> >>>>>>>> On Apr 19, 2016, at 9:34 PM, Greg Parker <gpar...@apple.com >>>>>>>> <mailto:gpar...@apple.com>> wrote: >>>>>>>> >>>>>>>> Looks like it was caused by the RR code motion merge >>>>>>>> (https://github.com/apple/swift/pull/2064 >>>>>>>> <https://github.com/apple/swift/pull/2064>). >>>>>>>> >>>>>>>> Xin, I'm planning to revert 49f1c66d7b20b29097d7aec99835c5a42a2048bf >>>>>>>> and 3824a9479ed2df701dffff4a0c9467495a4c37f0 once my tests finish, >>>>>>>> unless you have a fix in the next few minutes. >>>>>>>> >>>>>>>> >>>>>>>>> On Apr 19, 2016, at 8:50 PM, Erik Eckstein <eeckst...@apple.com >>>>>>>>> <mailto:eeckst...@apple.com>> wrote: >>>>>>>>> >>>>>>>>> This looks like there is some kind of non-determinism in the >>>>>>>>> compilation. >>>>>>>>> >>>>>>>>>> On Apr 19, 2016, at 8:14 PM, Greg Parker <gpar...@apple.com >>>>>>>>>> <mailto:gpar...@apple.com>> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On Apr 19, 2016, at 12:45 PM, no-re...@swift.org >>>>>>>>>>> <mailto:no-re...@swift.org> wrote: >>>>>>>>>>> >>>>>>>>>>> [FAILURE] oss-swift-incremental-RA-osx [#3504] >>>>>>>>>>> >>>>>>>>>>> Tests: >>>>>>>>>>> >>>>>>>>>>> Name: Swift >>>>>>>>>>> Failed: 1 test(s), Passed: 7808 test(s), Total: 7809 test(s) >>>>>>>>>>> • Failed: Swift.IRGen.module_hash.swift >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> This may be an older failure recently uncovered by changes to which >>>>>>>>>> tests get run. Jordan, Erik, any guesses of changes that might have >>>>>>>>>> broken it? >>>>>>>>>> >>>>>>>>>> Errors and recorded output below: >>>>>>>>>> >>>>>>>>>> /Volumes/precious/cvs/swift-github/swift/test/IRGen/module_hash.swift:49:15: >>>>>>>>>> error: expected string not found in input >>>>>>>>>> // CHECK-DAG: test.o: MD5=[[TEST4_MD5]] >>>>>>>>>> ^ >>>>>>>>>> <stdin>:21:1: note: scanning from here >>>>>>>>>> thread 0: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o >>>>>>>>>> ^ >>>>>>>>>> <stdin>:21:1: note: with variable "TEST4_MD5" equal to >>>>>>>>>> "c32902f17598124702a017fac0e9b86d" >>>>>>>>>> thread 0: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o >>>>>>>>>> ^ >>>>>>>>>> <stdin>:26:161: note: possible intended match here >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> MD5=e888cbc861bdeaaf786df90c4e5a40da >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> ^ >>>>>>>>>> /Volumes/precious/cvs/swift-github/swift/test/IRGen/module_hash.swift:59:15: >>>>>>>>>> error: expected string not found in input >>>>>>>>>> // CHECK-DAG: test.o: prev MD5=[[TEST4_MD5]] skipping >>>>>>>>>> ^ >>>>>>>>>> <stdin>:30:1: note: scanning from here >>>>>>>>>> thread 0: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o >>>>>>>>>> ^ >>>>>>>>>> <stdin>:30:1: note: with variable "TEST4_MD5" equal to >>>>>>>>>> "c32902f17598124702a017fac0e9b86d" >>>>>>>>>> thread 0: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o >>>>>>>>>> ^ >>>>>>>>>> <stdin>:35:161: note: possible intended match here >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> prev MD5=e888cbc861bdeaaf786df90c4e5a40da recompiling >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> ^ >>>>>>>>>> >>>>>>>>>> ---- >>>>>>>>>> >>>>>>>>>> single-threaded initial >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> MD5=bbfcd715eee1f17799113c1826dfe124 >>>>>>>>>> single-threaded same compilation >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> MD5=bbfcd715eee1f17799113c1826dfe124 >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> prev MD5=bbfcd715eee1f17799113c1826dfe124 skipping >>>>>>>>>> single-threaded file changed >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> MD5=bd6e3d5aef7c83992235017dacea08a9 >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> prev MD5=bbfcd715eee1f17799113c1826dfe124 recompiling >>>>>>>>>> single-threaded option changed >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> MD5=d67d06dfe12e11f7a2e4403461c646cd >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> prev MD5=bd6e3d5aef7c83992235017dacea08a9 recompiling >>>>>>>>>> multi-threaded initial >>>>>>>>>> thread 0: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o >>>>>>>>>> thread 1: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/simple.o >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/simple.o: >>>>>>>>>> MD5=a3b21cc67542538560df721fd14c5797 >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> MD5=c32902f17598124702a017fac0e9b86d >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> prev MD5=d67d06dfe12e11f7a2e4403461c646cd recompiling >>>>>>>>>> thread 1: done >>>>>>>>>> thread 0: done >>>>>>>>>> multi-threaded same compilation >>>>>>>>>> thread 0: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o >>>>>>>>>> thread 1: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/simple.o >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/simple.o: >>>>>>>>>> MD5=a3b21cc67542538560df721fd14c5797 >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/simple.o: >>>>>>>>>> prev MD5=a3b21cc67542538560df721fd14c5797 skipping >>>>>>>>>> thread 1: done >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> MD5=e888cbc861bdeaaf786df90c4e5a40da >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> prev MD5=c32902f17598124702a017fac0e9b86d recompiling >>>>>>>>>> thread 0: done >>>>>>>>>> multi-threaded one file changed >>>>>>>>>> thread 0: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o >>>>>>>>>> thread 1: fetched >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/simple.o >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/simple.o: >>>>>>>>>> MD5=1819daca599a35aa54bcdbad1251d8ac >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/simple.o: >>>>>>>>>> prev MD5=a3b21cc67542538560df721fd14c5797 recompiling >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> MD5=c32902f17598124702a017fac0e9b86d >>>>>>>>>> /Volumes/precious/cvs/swift-github/build/Ninja-RelWithDebInfoAssert+stdlib-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/IRGen/Output/module_hash.swift.tmp/test.o: >>>>>>>>>> prev MD5=e888cbc861bdeaaf786df90c4e5a40da recompiling >>>>>>>>>> thread 1: done >>>>>>>>>> thread 0: done >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Greg Parker gpar...@apple.com <mailto:gpar...@apple.com> >>>>>>>>>> Runtime Wrangler >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >>> _______________________________________________ >>> swift-dev mailing list >>> swift-dev@swift.org <mailto:swift-dev@swift.org> >>> https://lists.swift.org/mailman/listinfo/swift-dev >>> <https://lists.swift.org/mailman/listinfo/swift-dev> >> >
_______________________________________________ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev
