SGTM! Thanks!
> On Nov 16, 2016, at 12:02 PM, ankit_aggar...@apple.com wrote: > > I figured this was a 16.10 issue because PR bot (16.04) passed, however I > wasn't able to reproduce this locally after installing 16.10, I pushed a > commit to pin point the failure line but that integration went fine. I will > keep an eye if this comes again. > > Sent from my iPhone > > On 17-Nov-2016, at 12:57 AM, Michael Gottesman <mgottes...@apple.com > <mailto:mgottes...@apple.com>> wrote: > >> Question. How did this get through PR testing? >> >> Sent from my iPhone >> >> On Nov 16, 2016, at 6:01 AM, Ankit Aggarwal via swift-dev >> <swift-dev@swift.org <mailto:swift-dev@swift.org>> wrote: >> >>> This is mine, checking. >>> >>>> On 16-Nov-2016, at 6:12 PM, no-re...@swift.org <mailto:no-re...@swift.org> >>>> wrote: >>>> >>>> [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#519] >>>> >>>> Build URL: >>>> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/519/ >>>> <https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/519/> >>>> Project: oss-swift-incremental-RA-linux-ubuntu-16_10 >>>> Date of build: Wed, 16 Nov 2016 04:32:08 -0800 >>>> Build duration: 10 min >>>> Identified problems: >>>> >>>> Compile Error: This build failed because of a compile error. Below is a >>>> list of all errors in the build log: >>>> Indication 1 >>>> <https://ci.swift.org//job/oss-swift-incremental-RA-linux-ubuntu-16_10/519/consoleFull#614513942ee1a197b-acac-4b17-83cf-a53b95139a76> >>>> Tests: >>>> >>>> Name: Swift(linux-x86_64) >>>> Failed: 0 test(s), Passed: 8564 test(s), Total: 8564 test(s) >>>> Name: Swift-Unit >>>> Failed: 0 test(s), Passed: 299 test(s), Total: 299 test(s) >>>> >>>> Changes >>>> >>>> Commit 17a732b4d351d74f7bbb392d8cf6d1097b8bd10e by practicalswift: >>>> [swiftc (134 vs. 5198)] Add crasher in ? >>>> >>>> add: >>>> validation-test/compiler_crashers/28523-child-source-range-not-contained-within-its-parent-sequence-expr-type-null.swift >>>> >>>> Commit 8dac299dc3109a70ae1ce12c8cd9c201c562f9e6 by ankit_aggarwal: >>>> [PackageTool] Add pinning CLI >>>> >>>> edit: Tests/CommandsTests/PackageToolTests.swift >>>> edit: Sources/Commands/Workspace.swift >>>> edit: Sources/Commands/SwiftPackageTool.swift >>>> edit: Sources/Commands/Error.swift >>> >>> _______________________________________________ >>> swift-dev mailing list >>> swift-dev@swift.org <mailto:swift-dev@swift.org> >>> https://lists.swift.org/mailman/listinfo/swift-dev >>> <https://lists.swift.org/mailman/listinfo/swift-dev>
_______________________________________________ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev
