Looks like it wasn't me after all, source compatibility suite still fails in AsyncNinja even with my changes reverted - https://ci.swift.org/view/Source%20Compatibility/job/swift-master-source-compat-suite/391/
On Mon, Oct 2, 2017 at 6:58 PM, Pavel Yaskevich via swift-dev < swift-dev@swift.org> wrote: > Jordan, let's see if this helps because when I merged my original PR there > were no failures and only one target of AsyncNinja has been disabled, but I > noticed (just now) that all of them fail now which might actually not be my > fault... > > On Mon, Oct 2, 2017 at 6:44 PM, Pavel Yaskevich via swift-dev < > swift-dev@swift.org> wrote: > >> Merged revert into master https://github.com/appl >> e/swift/commit/9642ff0ba6018f5c236186627a3038627ea05a29 >> >> On Mon, Oct 2, 2017 at 4:36 PM, Pavel Yaskevich via swift-dev < >> swift-dev@swift.org> wrote: >> >>> Sorry it might be my commit actually, I am AFK for a bit, will revert >>> once I am back. >>> >>> Sent from my iPhone >>> >>> On Oct 2, 2017, at 3:48 PM, Jordan Rose via swift-dev < >>> swift-dev@swift.org> wrote: >>> >>> Anton just reupdated AsyncNinja, but it looks we have a new problem >>> there: >>> >>> /Users/buildnode/jenkins/workspace-private/swift-master-sour >>> ce-compat-suite/project_cache/AsyncNinja/Sources/Producer.swift:42:27: >>> error: ambiguous use of 'suffix' >>> _bufferedUpdates.push(bufferedUpdates.suffix(bufferSize)) >>> ^ >>> Swift.Sequence:301:17: note: found this candidate >>> public func suffix(_ maxLength: Int) -> Self.SubSequence >>> ^ >>> Swift.Sequence:53:17: note: found this candidate >>> public func suffix(_ maxLength: Int) -> AnySequence<Self.Element> >>> ^ >>> >>> >>> Pavel, there's already a bug for this, right? >>> >>> Jordan >>> >>> >>> >>> On Oct 2, 2017, at 15:44, no-re...@swift.org wrote: >>> >>> [FAILURE] swift-master-source-compat-suite [#389] >>> Build URL: https://ci.swift.org/job/swift-master-source-compat-suite/38 >>> 9/ >>> Project: swift-master-source-compat-suite >>> Date of build: Mon, 02 Oct 2017 15:15:01 -0500 >>> Build duration: 2 hr 30 min >>> Changes >>> >>> - Commit *001b09747a153763b30ef8a02254c7a0419c6292* by *pyaskevich:* >>> >>> [ConstraintSolver] Prioritize certain type variables while looking >>> for >>> - *edit*: test/Constraints/generics.swift >>> - *edit*: lib/Sema/CSSimplify.cpp >>> - *edit*: lib/Sema/CSBindings.cpp >>> - *edit*: lib/Sema/ConstraintSystem.h >>> >>> - Commit *6fe4ff8be7ab142ba7427c665b955770fc6905ba* by *mnvrth:* >>> >>> [CMake] Fix status message when not building stdlib/runtime >>> - *edit*: CMakeLists.txt >>> >>> - Commit *5ba1522874a46b85df8de7cd6bd4f4d1d41ab4a7* by *mnvrth:* >>> >>> [CMake] Improve wording of stdlib/overlay/runtime build status >>> - *edit*: CMakeLists.txt >>> >>> - Commit *f2ef42baed96e16086481537cc7dc87bbd2368b0* by *github:* >>> >>> [migrator] When renaming a function decl, we should use underscore to >>> - *edit*: lib/Migrator/APIDiffMigratorPass.cpp >>> - *edit*: test/Migrator/Inputs/Cities.swift >>> - *edit*: test/Migrator/rename-func-decl.swift >>> - *edit*: test/Migrator/rename-func-decl.swift.expected >>> - *edit*: test/Migrator/Inputs/API.json >>> >>> - Commit *c47287199bce9b4d2c9ae0dc308dc328461ce9f6* by *arthur:* >>> >>> Updated Guitar support for Swift 4.0 >>> - *edit*: projects.json >>> >>> - Commit *1a82e4d490d4607da81f58327eb0f900f3056c08* by >>> *antonvmironov:* >>> >>> AsyncNinja updated. https://bugs.swift.org/browse/SR-5998 fixed >>> - *edit*: projects.json >>> >>> - Commit *ce4cf094fabf5b5e306b6b7b5cf65461ab681d7b* by *arthur:* >>> >>> Re-added 3.1 compatibility >>> - *edit*: projects.json >>> >>> - Commit *632bf4e2201eb4d2d3cfb9a594f02e4bfc5f6a3a* by *arthur:* >>> >>> Removed comma >>> - *edit*: projects.json >>> >>> - Commit *87ebe010aedc3bd89d351f8b0ecc7ffdd0ea8494* by >>> *antonvmironov:* >>> >>> UnXFAIL AsyncNinja >>> - *edit*: projects.json >>> >>> >>> _______________________________________________ >>> swift-dev mailing list >>> swift-dev@swift.org >>> https://lists.swift.org/mailman/listinfo/swift-dev >>> >>> >>> _______________________________________________ >>> swift-dev mailing list >>> swift-dev@swift.org >>> https://lists.swift.org/mailman/listinfo/swift-dev >>> >>> >> >> _______________________________________________ >> swift-dev mailing list >> swift-dev@swift.org >> https://lists.swift.org/mailman/listinfo/swift-dev >> >> > > _______________________________________________ > swift-dev mailing list > swift-dev@swift.org > https://lists.swift.org/mailman/listinfo/swift-dev > >
_______________________________________________ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev