Created PR https://github.com/apple/swift/pull/12852
> On Nov 9, 2017, at 6:15 PM, Pavel Yaskevich <pyaskev...@apple.com> wrote: > > > >> On Nov 9, 2017, at 6:02 PM, Ahmed Bougacha <ahmed.bouga...@gmail.com >> <mailto:ahmed.bouga...@gmail.com>> wrote: >> >> >> >> On Thu, Nov 9, 2017 at 5:51 PM, Ahmed Bougacha <ahmed.bouga...@gmail.com >> <mailto:ahmed.bouga...@gmail.com>> wrote: >> >> On Thu, Nov 9, 2017 at 5:41 PM, Pavel Yaskevich <pyaskev...@apple.com >> <mailto:pyaskev...@apple.com>> wrote: >> Hi Ahmed, >> >> There is a problem in CodeGen: >> >> /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-14_04/llvm/tools/clang/lib/CodeGen/CodeGenAction.cpp:50:47: >> error: expected class name >> class ClangDiagnosticHandler final : public DiagnosticHandler { >> >> Can you please take a look? >> >> >> Huh, that should be handled by the associated clang commits. I'm only >> seeing a similar issue in swift (you probably need to cherry-pick something >> similar, related to opt-remarks): >> >> /home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/swift/lib/Immediate/Immediate.cpp:200:28: >> error: reference to type 'std::unique_ptr<DiagnosticHandler>' could not >> bind to an lvalue of type 'void (const llvm::DiagnosticInfo &, void *)' >> Ctx.setDiagnosticHandler(linkerDiagnosticHandler, nullptr); >> ^~~~~~~~~~~~~~~~~~~~~~~ >> /home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/llvm/include/llvm/IR/LLVMContext.h:211:66: >> note: passing argument to parameter 'DH' here >> void setDiagnosticHandler(std::unique_ptr<DiagnosticHandler> &&DH, >> ^ >> /home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/swift/lib/Immediate/Immediate.cpp:202:28: >> error: rvalue reference to type 'unique_ptr<[2 * ...]>' cannot bind to >> lvalue of type 'unique_ptr<[2 * ...]>' >> Ctx.setDiagnosticHandler(OldHandler, OldDiagnosticContext); >> ^~~~~~~~~~ >> /home/buildnode/jenkins/workspace/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/llvm/include/llvm/IR/LLVMContext.h:211:66: >> note: passing argument to parameter 'DH' here >> void setDiagnosticHandler(std::unique_ptr<DiagnosticHandler> &&DH, >> ^ >> 2 errors generated. >> >> at: >> https://ci.swift.org//job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/138/consoleFull#-20360024703122a513-f36a-4c87-8ed7-cbc36a1ec144 >> >> <https://ci.swift.org//job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/138/consoleFull#-20360024703122a513-f36a-4c87-8ed7-cbc36a1ec144> >> >> Where's the clang error? >> >> Oh I found it in some other bot: >> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/1500/consoleFull#4577411573122a513-f36a-4c87-8ed7-cbc36a1ec144 >> >> <https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/1500/consoleFull#4577411573122a513-f36a-4c87-8ed7-cbc36a1ec144> >> >> As expect, it went away with the next run, where the matching LLVM commits >> went in: >> https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/1501/consoleFull#-732692253122a513-f36a-4c87-8ed7-cbc36a1ec144 >> >> <https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/1501/consoleFull#-732692253122a513-f36a-4c87-8ed7-cbc36a1ec144> >> >> But now there's still the swift issues. I'll let you folks figure that out; >> sorry for the breakage! > > No problem, we’ll deal with it! > >> >> -Ahmed >> >> -Ahmed >> >> Best Regards, Pavel. >> >>> On Nov 9, 2017, at 5:33 PM, no-re...@swift.org <mailto:no-re...@swift.org> >>> wrote: >>> >>> New issue found! >>> >>> [FAILURE] oss-swift-4.1-incremental-RA-linux-ubuntu-16_10 [#138] >>> >>> Build URL: >>> https://ci.swift.org/job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/138/ >>> >>> <https://ci.swift.org/job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/138/> >>> Project: oss-swift-4.1-incremental-RA-linux-ubuntu-16_10 >>> Date of build: Thu, 09 Nov 2017 19:16:22 -0600 >>> Build duration: 16 min >>> Identified problems: >>> >>> Compile Error: This build failed because of a compile error. Below is a >>> list of all errors in the build log: >>> Indication 1 >>> <https://ci.swift.org//job/oss-swift-4.1-incremental-RA-linux-ubuntu-16_10/138/consoleFull#-20360024703122a513-f36a-4c87-8ed7-cbc36a1ec144> >>> Changes >>> >>> Commit 97adc5f12e40263ddb9a675a02f432c65daaee71 by ahmed.bougacha: >>> [MIR] Print target-specific constant pools >>> >>> edit: lib/CodeGen/MIRPrinter.cpp >>> edit: test/CodeGen/MIR/X86/constant-pool.mir >>> edit: include/llvm/CodeGen/MIRYamlMapping.h >>> add: test/CodeGen/MIR/ARM/target-constant-pools-error.mir >>> edit: lib/CodeGen/MIRParser/MIRParser.cpp >>> >>> Commit bebdcae7d9fa45851b2f8a819b6c230115e76490 by ahmed.bougacha: >>> [CodeGen] Fix some Clang-tidy modernize and Include What You Use >>> >>> edit: include/llvm/CodeGen/MIRYamlMapping.h >>> >>> Commit 66210e84c48072979e39cc4039c54042131ddab9 by ahmed.bougacha: >>> [GlobalISel][X86] G_FCONSTANT support. >>> >>> edit: lib/Target/X86/X86InstructionSelector.cpp >>> add: test/CodeGen/X86/GlobalISel/select-fconstant.mir >>> edit: lib/Target/X86/X86RegisterBankInfo.cpp >>> edit: lib/Target/X86/X86LegalizerInfo.cpp >>> add: test/CodeGen/X86/GlobalISel/fconstant.ll >>> edit: test/CodeGen/X86/GlobalISel/regbankselect-X86_64.mir >>> edit: test/CodeGen/X86/GlobalISel/legalize-constant.mir >>> >>> Commit 121242ac03980a7c3ba46a7de539694fcbaa2c62 by ahmed.bougacha: >>> [GlobalISel][X86] Use correct physical register in mir tests.NFC. >>> >>> edit: test/CodeGen/X86/GlobalISel/legalize-ext.mir >>> edit: test/CodeGen/X86/GlobalISel/select-undef.mir >>> edit: test/CodeGen/X86/GlobalISel/select-or-scalar.mir >>> edit: test/CodeGen/X86/GlobalISel/select-add.mir >>> edit: test/CodeGen/X86/GlobalISel/select-unmerge-vec512.mir >>> edit: test/CodeGen/X86/GlobalISel/select-and-scalar.mir >>> edit: test/CodeGen/X86/GlobalISel/legalize-insert-vec512.mir >>> edit: test/CodeGen/X86/GlobalISel/select-ext-x86-64.mir >>> edit: test/CodeGen/X86/GlobalISel/select-phi.mir >>> edit: test/CodeGen/X86/GlobalISel/legalize-mul-scalar.mir >>> edit: test/CodeGen/X86/GlobalISel/select-ext.mir >>> edit: test/CodeGen/X86/GlobalISel/legalize-cmp.mir >>> edit: test/CodeGen/X86/GlobalISel/regbankselect-X86_64.mir >>> edit: test/CodeGen/X86/GlobalISel/legalize-phi.mir >>> edit: test/CodeGen/X86/GlobalISel/select-mul-scalar.mir >>> edit: test/CodeGen/X86/GlobalISel/select-cmp.mir >>> edit: test/CodeGen/X86/GlobalISel/legalize-ext-x86-64.mir >>> edit: test/CodeGen/X86/GlobalISel/select-insert-vec512.mir >>> edit: test/CodeGen/X86/GlobalISel/select-xor-scalar.mir >>> >>> Commit 6a3164df8f2c3e6cdd5ad806b5bdc8cfe97dafac by ahmed.bougacha: >>> [GlobalISel][X86] Legalize i1 G_ADD/G_SUB/G_MUL/G_XOR/G_OR/G_AND >>> >>> edit: test/CodeGen/X86/GlobalISel/legalize-add.mir >>> edit: test/CodeGen/X86/GlobalISel/add-scalar.ll >>> add: test/CodeGen/X86/GlobalISel/sub-scalar.ll >>> edit: lib/Target/X86/X86LegalizerInfo.cpp >>> edit: test/CodeGen/X86/GlobalISel/legalize-and-scalar.mir >>> edit: test/CodeGen/X86/GlobalISel/legalize-xor-scalar.mir >>> edit: test/CodeGen/X86/GlobalISel/legalize-mul-scalar.mir >>> edit: test/CodeGen/X86/GlobalISel/and-scalar.ll >>> edit: test/CodeGen/X86/GlobalISel/xor-scalar.ll >>> edit: test/CodeGen/X86/GlobalISel/legalize-or-scalar.mir >>> edit: test/CodeGen/X86/GlobalISel/legalize-sub.mir >>> edit: test/CodeGen/X86/GlobalISel/or-scalar.ll >>> >>> Commit 736be99a0dd878ec734bf7aa455906e772ee6be5 by ahmed.bougacha: >>> [GlobalISel][X86] refactoring X86InstructionSelector.cpp .NFC. >>> >>> edit: lib/Target/X86/X86InstructionSelector.cpp >>> >>> Commit 9881d01abf1a02ca2a2e174dfb16a2f49a21e2ef by ahmed.bougacha: >>> Split opt-remark YAML and opt output testing on this test >>> >>> edit: test/Transforms/GVN/opt-remarks.ll >>> >>> Commit 13c9ccabd4d81a8ceb36abc2bfcf52497a9be844 by ahmed.bougacha: >>> Improve comment >>> >>> edit: include/llvm/Analysis/OptimizationDiagnosticInfo.h >>> >>> Commit 42a3c53004c2529fbfcb6e4bbe8391880aa6667a by ahmed.bougacha: >>> This patch fixes https://bugs.llvm.org/show_bug.cgi?id=32352 >>> <https://bugs.llvm.org/show_bug.cgi?id=32352> It enables >>> >>> edit: include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h >>> edit: tools/llvm-link/llvm-link.cpp >>> edit: lib/IR/LLVMContextImpl.cpp >>> add: include/llvm/IR/DiagnosticHandler.h >>> edit: lib/IR/DiagnosticInfo.cpp >>> edit: tools/llc/llc.cpp >>> edit: lib/Transforms/Scalar/GVN.cpp >>> edit: tools/lto/lto.cpp >>> add: lib/IR/DiagnosticHandler.cpp >>> edit: include/llvm/LTO/Config.h >>> edit: lib/IR/LLVMContext.cpp >>> edit: lib/IR/LLVMContextImpl.h >>> edit: test/Transforms/GVN/opt-remarks.ll >>> edit: tools/llvm-dis/llvm-dis.cpp >>> edit: lib/IR/Core.cpp >>> edit: lib/Transforms/Vectorize/LoopVectorize.cpp >>> edit: include/llvm/Analysis/OptimizationDiagnosticInfo.h >>> edit: include/llvm/LTO/legacy/LTOCodeGenerator.h >>> edit: lib/LTO/LTOCodeGenerator.cpp >>> edit: include/llvm/IR/LLVMContext.h >>> edit: tools/llvm-lto/llvm-lto.cpp >>> edit: include/llvm/IR/DiagnosticInfo.h >>> edit: lib/IR/CMakeLists.txt >>> >>> Commit 7e92e11fef4d76d8a9d04115a76a032ae3957548 by ahmed.bougacha: >>> Allow ORE.emit to take a closure to delay building the remark object >>> >>> edit: lib/IR/DiagnosticInfo.cpp >>> edit: include/llvm/IR/DiagnosticInfo.h >>> edit: include/llvm/IR/DiagnosticHandler.h >>> edit: include/llvm/Analysis/OptimizationDiagnosticInfo.h >>> edit: lib/IR/DiagnosticHandler.cpp >>> >>> Commit cb23c2b83f82388ede37e1d1805c73f35eb6666d by ahmed.bougacha: >>> Fix build for LLVM unittests >>> >>> edit: unittests/Linker/LinkModulesTest.cpp >>> >>> Commit 977c701bfe137665dff3f6d09808b71ce40210a2 by ahmed.bougacha: >>> [GlobalISel] Only build expensive remarks if they're enabled. NFC. >>> >>> edit: lib/CodeGen/GlobalISel/Utils.cpp >>> edit: lib/CodeGen/GlobalISel/IRTranslator.cpp >>> >>> Commit c94ff728d8d1155a8594e992b0a83dc8fa3fc85d by ahmed.bougacha: >>> [globalisel] Add support for intrinsic_w_chain. >>> >>> add: test/CodeGen/X86/GlobalISel/select-intrinsic-x86-flags-read-u32.mir >>> edit: include/llvm/Target/GlobalISel/SelectionDAGCompat.td >>> edit: utils/TableGen/GlobalISelEmitter.cpp >>> >>> Commit 45db2d984b6241c49bdf1a2406bec7565f7cac94 by ahmed.bougacha: >>> [globalisel] Add support for intrinsic_void >>> >>> edit: include/llvm/Target/GlobalISel/SelectionDAGCompat.td >>> add: test/CodeGen/AArch64/GlobalISel/select-intrinsic-aarch64-hint.mir >>> >>> Commit ddb01fed5e7d30f2d372d49ce81e3ea1b74f85a8 by ahmed.bougacha: >>> [globalisel] Add a G_BSWAP instruction and support bswap using it. >>> >>> edit: include/llvm/Target/TargetOpcodes.def >>> edit: lib/Target/AArch64/AArch64LegalizerInfo.cpp >>> add: test/CodeGen/AArch64/GlobalISel/select-bswap.mir >>> edit: include/llvm/Target/GenericOpcodes.td <http://odes.td/> >>> edit: include/llvm/Target/GlobalISel/SelectionDAGCompat.td >>> >>> Commit bd502f2f0000a8ebe30f328d4e41ed59e8d40368 by ahmed.bougacha: >>> [MIRPrinter] Print empty successor lists when they cannot be guessed >>> >>> edit: test/CodeGen/MIR/ARM/ifcvt_canFallThroughTo.mir >>> add: test/CodeGen/MIR/X86/unreachable_block.ll >>> edit: lib/CodeGen/MIRPrinter.cpp >>> >>> Commit 213db310e21e190687471662b2e8d238b3273659 by ahmed.bougacha: >>> [ARM] Fix some Clang-tidy modernize-use-using and Include What You Use >>> >>> edit: lib/Target/ARM/ARMCallLowering.h >>> edit: lib/Target/ARM/ARMCallLowering.cpp >>> >>> Commit eb8a047cbe0a9e2290b1e80e561cd9d6ea55a01f by ahmed.bougacha: >>> [GlobalISel] Update the documentation and comments for G_EXTRACT >>> >>> edit: docs/GlobalISel.rst >>> edit: include/llvm/Target/GenericOpcodes.td <http://odes.td/> >>> Commit a0555e9f3951aea6057c1f174cd3aaa40e9c67c0 by ahmed.bougacha: >>> [GlobalISel] Update the documentation for G_SEQUENCE >>> >>> edit: docs/GlobalISel.rst >>> >>> Commit ad3f195ed233bce75f1ad915e9d4aadb66427b2a by ahmed.bougacha: >>> [GlobalISel] Update the documentation and comment for G_[UN]MERGE_VALUES >>> >>> edit: docs/GlobalISel.rst >>> edit: include/llvm/Target/GenericOpcodes.td <http://odes.td/> >>> Commit 031892702a0314ead57fd9e002909caf61205811 by ekarpenkov: >>> Revert "Add _Float16 as a C/C++ source language type" >>> >>> edit: lib/Index/USRGeneration.cpp >>> edit: lib/AST/StmtPrinter.cpp >>> edit: lib/CodeGen/CGExprScalar.cpp >>> edit: lib/CodeGen/CGDebugInfo.cpp >>> edit: lib/Serialization/ASTReader.cpp >>> edit: lib/Format/FormatToken.cpp >>> edit: lib/Sema/SemaDecl.cpp >>> edit: lib/Sema/SemaType.cpp >>> edit: lib/Sema/SemaExpr.cpp >>> edit: include/clang-c/Index.h >>> edit: lib/CodeGen/ItaniumCXXABI.cpp >>> edit: lib/Parse/ParseTentative.cpp >>> edit: include/clang/Lex/LiteralSupport.h >>> edit: lib/Lex/LiteralSupport.cpp >>> edit: include/clang/Basic/Specifiers.h >>> delete: test/Frontend/float16.cpp >>> edit: include/clang/AST/ASTContext.h >>> edit: lib/CodeGen/CodeGenTypes.cpp >>> edit: lib/Parse/ParseExpr.cpp >>> edit: lib/Serialization/ASTCommon.cpp >>> edit: lib/Parse/ParseExprCXX.cpp >>> edit: lib/Sema/SemaTemplateVariadic.cpp >>> edit: lib/AST/Type.cpp >>> edit: include/clang/Serialization/ASTBitCodes.h >>> edit: include/clang/Basic/TokenKinds.def >>> edit: lib/AST/TypeLoc.cpp >>> edit: lib/AST/MicrosoftMangle.cpp >>> edit: lib/AST/ASTContext.cpp >>> edit: lib/AST/NSAPI.cpp >>> edit: lib/Analysis/PrintfFormatString.cpp >>> edit: lib/Parse/ParseDecl.cpp >>> delete: test/CodeGenCXX/float16-declarations.cpp >>> edit: tools/libclang/CXType.cpp >>> edit: lib/AST/ItaniumMangle.cpp >>> edit: lib/Sema/DeclSpec.cpp >>> edit: test/Lexer/half-literal.cpp >>> edit: include/clang/Sema/DeclSpec.h >>> edit: include/clang/AST/BuiltinTypes.def >>> >>> Commit 11f34cfdd31ec9552df7fb7679064c0375c7f34f by ahmed.bougacha: >>> This patch fixes https://bugs.llvm.org/show_bug.cgi?id=32352 >>> <https://bugs.llvm.org/show_bug.cgi?id=32352> LLVM code >>> >>> edit: lib/CodeGen/CodeGenAction.cpp >>> >>> Commit cae699c147cc75c5eeabf6d452384b4ee76fc3f8 by ahmed.bougacha: >>> Fix ClangDiagnosticHandler::is*RemarkEnabled members >>> >>> edit: lib/CodeGen/CodeGenAction.cpp >>> add: test/Frontend/optimization-remark-extra-analysis.c
_______________________________________________ swift-dev mailing list swift-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-dev
