• What is your evaluation of the proposal?
+1
• Is the problem being addressed significant enough to warrant a
change to Swift?
Yes
• Does this proposal fit well with the feel and direction of Swift?
Yes.
• If you have used other languages or libraries with a similar
feature, how do you feel that this proposal compares to those?
• How much effort did you put into your review? A glance, a quick
reading, or an in-depth study?
`=` vs `==` is a common and subtle case. I consider the all of the
comparison operators and our overloads thereof to be the most compelling
argument in favor of this change. It only occurred to me recently that I
should add `@warn_unused_result` on *every* custom implementation of `==`
and `<` This proposal remedies that problem.
On Wed, Mar 16, 2016 at 1:36 PM, Chris Lattner via swift-evolution <
[email protected]> wrote:
> Hello Swift community,
>
> The review of “Defaulting non-Void functions so they warn on unused
> results” begins now and runs through March 21, 2016. The proposal is
> available here:
>
>
> https://github.com/apple/swift-evolution/blob/master/proposals/0047-nonvoid-warn.md
>
> Reviews are an important part of the Swift evolution process. All reviews
> should be sent to the swift-evolution mailing list at:
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
> or, if you would like to keep your feedback private, directly to the
> review manager. When replying, please try to keep the proposal link at the
> top of the message:
>
> What goes into a review?
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Swift. When writing your review, here are some questions you might want to
> answer in your review:
>
> • What is your evaluation of the proposal?
> • Is the problem being addressed significant enough to warrant a
> change to Swift?
> • Does this proposal fit well with the feel and direction of Swift?
> • If you have used other languages or libraries with a similar
> feature, how do you feel that this proposal compares to those?
> • How much effort did you put into your review? A glance, a quick
> reading, or an in-depth study?
>
> More information about the Swift evolution process is available at:
>
> https://github.com/apple/swift-evolution/blob/master/process.md
>
> Thank you,
>
> -Chris
> Review Manager
>
>
> _______________________________________________
> swift-evolution mailing list
> [email protected]
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
_______________________________________________
swift-evolution mailing list
[email protected]
https://lists.swift.org/mailman/listinfo/swift-evolution
