> What is your evaluation of the proposal? +1
> Is the problem being addressed significant enough to warrant a change to Swift? Yes, with reservations. The proposal itself mentions that this may be a temporary solution, and while I believe temporary solutions tend to add more complexity over the long-term, and tend to end up being not-so-temporary, I think interfacing well with Objective-C in a type safe manner is important. > Does this proposal fit well with the feel and direction of Swift? Yes, I would consider this to be a natural extension of SE-0022. In fact, I think SE-0022 isn't really complete without this. > If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those? There are two ways to think of this feature: As a worse alternative to lenses, and as a more type-safe mechanism for interoperating with Objective-C. The proposal already covers the first, acknowledging that lenses are out-of-scope for Swift 3. As for the second, I have used other languages with Objective-C bridges, and all of them dealt with this problem by simply using foo for the getter, and setFoo: for the setter. This approach has the advantage over SE-0064 of not requiring any additional overloads, and I'm not quite sure why SE-0022 wasn't just implemented this way to begin with. Because it keeps the language simpler, I probably would have advocated for this approach, but I don't think the impact is particularly large, and since SE-0064 is already at the proposal stage, it's probably just water under the bridge at this point. > How much effort did you put into your review? A glance, a quick reading, or an in-depth study? I read through the proposal and the previous two threads, and thought about it for a few minutes. On Thu, Apr 7, 2016 at 1:57 PM, Douglas Gregor <[email protected]> wrote: > Hello Swift community, > > The review of SE-0064 "Referencing the Objective-C selector of property > getters and setters" begins now and runs through April 12, 2016. The > proposal is available here: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0064-property-selectors.md > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > > https://lists.swift.org/mailman/listinfo/swift-evolution > > or, if you would like to keep your feedback private, directly to the > review manager. When replying, please try to keep the proposal link at the > top of the message: > > Proposal link: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0064-property-selectors.md > > Reply text > > Other replies > > <https://github.com/apple/swift-evolution#what-goes-into-a-review-1>What > goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and, eventually, determine the direction of > Swift. When writing your review, here are some questions you might want to > answer in your review: > > - What is your evaluation of the proposal? > - Is the problem being addressed significant enough to warrant a > change to Swift? > - Does this proposal fit well with the feel and direction of Swift? > - If you have used other languages or libraries with a similar > feature, how do you feel that this proposal compares to those? > - How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > > More information about the Swift evolution process is available at > > https://github.com/apple/swift-evolution/blob/master/process.md > > Thank you, > > Doug Gregor > > Review Manager > > _______________________________________________ > swift-evolution-announce mailing list > [email protected] > https://lists.swift.org/mailman/listinfo/swift-evolution-announce > >
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
