Karl - Absolute value of `Int.min` is currently not representable by an Int.
On Wed, Jun 22, 2016 at 9:32 PM, Karl via swift-evolution < [email protected]> wrote: > +1 > > Looks very good. A couple of points: > > - I’m not convinced about ‘absoluteValue’, with an associated type. I > think it should return the same value as ‘abs()’ or have a different name > if it’s really needed at all; the example of a print function is a bit weak > IMO. > - I’m not sure about an ‘nthWord()’ getter without a corresponding setter. > - I would like ‘floor’ and ‘ceil’ to be part of the standard library (or > some equivalent). It annoys me that I have to import Darwin/Glibc to > properly convert between standard library types. Would this go with the > initialisers from FloatingPoint on Integer, or somewhere on FloatingPoint? > > Definitely a step up from what we have, and a good foundation to build on. > > Karl > > > On 23 Jun 2016, at 02:52, Chris Lattner via swift-evolution < > [email protected]> wrote: > > > > Hello Swift community, > > > > The review of "SE-0104: Protocol-oriented integers" begins now and runs > through June 27. The proposal is available here: > > > > > https://github.com/apple/swift-evolution/blob/master/proposals/0104-improved-integers.md > > > > Reviews are an important part of the Swift evolution process. All > reviews should be sent to the swift-evolution mailing list at > > > > https://lists.swift.org/mailman/listinfo/swift-evolution > > > > or, if you would like to keep your feedback private, directly to the > review manager. > > > > What goes into a review? > > > > The goal of the review process is to improve the proposal under review > through constructive criticism and contribute to the direction of Swift. > When writing your review, here are some questions you might want to answer > in your review: > > > > * What is your evaluation of the proposal? > > * Is the problem being addressed significant enough to warrant a > change to Swift? > > * Does this proposal fit well with the feel and direction of Swift? > > * If you have used other languages or libraries with a similar > feature, how do you feel that this proposal compares to those? > > * How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > > > > More information about the Swift evolution process is available at > > > > https://github.com/apple/swift-evolution/blob/master/process.md > > > > Thank you, > > > > -Chris Lattner > > Review Manager > > > > > > _______________________________________________ > > swift-evolution mailing list > > [email protected] > > https://lists.swift.org/mailman/listinfo/swift-evolution > > _______________________________________________ > swift-evolution mailing list > [email protected] > https://lists.swift.org/mailman/listinfo/swift-evolution >
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
