> On 1 Jul 2016, at 14:13, Taras Zakharko via swift-evolution > <swift-evolution@swift.org> wrote: > >> >> The goal of the review process is to improve the proposal under review >> through constructive criticism and contribute to the direction of Swift. >> When writing your review, here are some questions you might want to answer >> in your review: >> >> * What is your evaluation of the proposal? > > In principle +1, but I’d prefer if the proposal also included rounding with a > specified precision. I.e. > > func rounded(_ rule: RoundingRule = toNearestOrAwayFromZero, decimalPlaces > digits: Int = 0) -> Self >
Rounding with specified precision was discussed, but excluded from the proposal. It could be mentioned in the Alternatives Considered why it's not part of this proposal. > >> * Is the problem being addressed significant enough to warrant a change >> to Swift? > > yes > >> * Does this proposal fit well with the feel and direction of Swift? > > yes > >> * If you have used other languages or libraries with a similar feature, >> how do you feel that this proposal compares to those? > > yes. I like how the proposal accounts for the rounding rule. However, what is > missing is rounding with specified precision > >> * How much effort did you put into your review? A glance, a quick >> reading, or an in-depth study? > > glance > > _______________________________________________ > swift-evolution mailing list > swift-evolution@swift.org > https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________ swift-evolution mailing list swift-evolution@swift.org https://lists.swift.org/mailman/listinfo/swift-evolution
