> * What is your evaluation of the proposal? +1. I would like to see .awayFromZero added as an option as well. It is occasionally useful, and it would provide symmetry.
I would also like to see rounding precision as well, but that can be added later, so don’t let it stop this proposal > * Is the problem being addressed significant enough to warrant a change to > Swift? I think it is within scope of building the FloatingPoint protocol. I would miss it if it wasn’t there... > * Does this proposal fit well with the feel and direction of Swift? Yes, I like the use of an enum to specify the rounding type (as opposed to separate functions) with a common default. > * If you have used other languages or libraries with a similar feature, how > do you feel that this proposal compares to those? This is much nicer than separate free functions for each type of rounding (which is what pretty much everything else I have used has). I have found the rounding options for NSDecimalNumber very useful in the past. > * How much effort did you put into your review? A glance, a quick reading, or > an in-depth study? A quick read. Thanks, Jon > Hello Swift community, > > The review of "SE-0113: Add integral rounding functions to FloatingPoint" > begins now and runs through July 5. The proposal is available here: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0113-rounding-functions-on-floatingpoint.md > > <https://github.com/apple/swift-evolution/blob/master/proposals/0113-rounding-functions-on-floatingpoint.md> > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > > https://lists.swift.org/mailman/listinfo/swift-evolution > <https://lists.swift.org/mailman/listinfo/swift-evolution> > > or, if you would like to keep your feedback private, directly to the review > manager. > > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and contribute to the direction of Swift. When > writing your review, here are some questions you might want to answer in your > review: > > * What is your evaluation of the proposal? > * Is the problem being addressed significant enough to warrant a change > to Swift? > * Does this proposal fit well with the feel and direction of Swift? > * If you have used other languages or libraries with a similar feature, > how do you feel that this proposal compares to those? > * How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > > More information about the Swift evolution process is available at > > https://github.com/apple/swift-evolution/blob/master/process.md > <https://github.com/apple/swift-evolution/blob/master/process.md> > > Thank you, > > -Chris Lattner > Review Manager
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
