On Tue, Jul 5, 2016 at 7:11 PM, Chris Lattner via swift-evolution < [email protected]> wrote:
> Hello Swift community, > > The review of "SE-0117: Default classes to be non-subclassable publicly" > begins now and runs through July 11. The proposal is available here: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0117-non-public-subclassable-by-default.md > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > > https://lists.swift.org/mailman/listinfo/swift-evolution > > or, if you would like to keep your feedback private, directly to the > review manager. > > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and contribute to the direction of Swift. > When writing your review, here are some questions you might want to answer > in your review: > > * What is your evaluation of the proposal? > A strong +1 to the new default. I agree with others that having two keywords that also conflate/imply public access is less than ideal. Having a `public(open) class` or `public open class` would be better in my opinion. > * Is the problem being addressed significant enough to warrant a > change to Swift? > Yes. > * Does this proposal fit well with the feel and direction of Swift? > Yes. Requiring extra keywords and safety at module boundaries to clarify intent has been a philosophy toward Swift language changes. > * If you have used other languages or libraries with a similar > feature, how do you feel that this proposal compares to those? > N/A > * How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > Read the proposal as well as this and earlier discussions. > > More information about the Swift evolution process is available at > > https://github.com/apple/swift-evolution/blob/master/process.md > > Thank you, > > -Chris Lattner > Review Manager > > _______________________________________________ > swift-evolution mailing list > [email protected] > https://lists.swift.org/mailman/listinfo/swift-evolution > -- Trent Nadeau
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
