Hi Swift community > * What is your evaluation of the proposal? The proposal looks good and it solves the addressed problems. Resolving dependency graph is not a trivial problem and I like how this proposal tackles 1 problem at the time.
> * Is the problem being addressed significant enough to warrant a change to > Swift? Yes it does. With the "Version Pinning" it would be very convenient to share that information with others > Does this proposal fit well with the feel and direction of Swift? Yes it does. > If you have used other languages or libraries with a similar feature, how do > you feel that this proposal compares to those? Some other dependency managers choose to generate pin files by default. I feel it's a correct choice to make "Pin file" optional since SwiftPM requires a versioning tag for a dependency (which is option in others dependency managers I've used) > * How much effort did you put into your review? A glance, a quick reading, or > an in-depth study? I tried to study more about dependency pinning and locking, how they are implemented tin other dependency manager and what impact they have. Additional notes: When I run swift package update on unpinned package, would it be possible to roll back to previously used dependencies? Use case: Let's say I have a package with a dependency A .Package(url: "https://A.git";, versions: Version(1,0,0)..<Version(2,0,0)), At first fetch I get A dependency with v1.0. Then I run `swift package update` and A gets updated to 1.1 The package is not pinned. If that dependency update break my package is there an easy way for me to roll back? Best Regards Kostiantyn > On 31 Oct 2016, at 22:23, Anders Bertelrud via swift-evolution > <[email protected]> wrote: > > Hello Swift community, > > The review of SE-0145 "Package Manager Version Pinning" begins now and runs > through November 4. The proposal is available here: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md > > <https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md> > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > > https://lists.swift.org/mailman/listinfo/swift-evolution > <https://lists.swift.org/mailman/listinfo/swift-evolution> > > or, if you would like to keep your feedback private, directly to the review > manager. > > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and contribute to the direction of Swift. When > writing your review, here are some questions you might want to answer in your > review: > > * What is your evaluation of the proposal? > * Is the problem being addressed significant enough to warrant a change > to Swift? > * Does this proposal fit well with the feel and direction of Swift? > * If you have used other languages or libraries with a similar feature, > how do you feel that this proposal compares to those? > * How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > > More information about the Swift evolution process is available at > > https://github.com/apple/swift-evolution/blob/master/process.md > <https://github.com/apple/swift-evolution/blob/master/process.md> > > Thank you, > > Anders Bertelrud > Review Manager > _______________________________________________ > swift-evolution mailing list > [email protected] > https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
