> On Mar 7, 2017, at 12:53 PM, Rick Ballard via swift-build-dev
> <[email protected]> wrote:
>
> Hello Swift community,
>
> The review of "SE-0158 Package Manager Manifest API Redesign" begins now and
> runs through March 13, 2017. The proposal is available here:
>
>
> https://github.com/apple/swift-evolution/blob/master/proposals/0158-package-manager-manifest-api-redesign.md
>
> <https://github.com/apple/swift-evolution/blob/master/proposals/0158-package-manager-manifest-api-redesign.md>
>
> Reviews are an important part of the Swift evolution process. All Swift
> Package Manager reviews should be sent to the swift-evolution and
> swift-build-dev mailing lists at
>
> https://lists.swift.org/mailman/listinfo/swift-evolution
> https://lists.swift.org/mailman/listinfo/swift-build-dev
>
> or, if you would like to keep your feedback private, directly to the review
> manager. When replying, please try to keep the proposal link at the top of
> the message:
>
> > Proposal link:
> >>
> >> https://github.com/apple/swift-evolution/blob/master/proposals/0158-package-manager-manifest-api-redesign.md
>
> > Reply text
>
> >> Other replies
>
> What goes into a review?
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Swift. When writing your review, here are some questions you might want to
> answer in your review:
>
> * What is your evaluation of the proposal?
+1, although I don’t know why we're supporting this:
// 1.5.8 ..< 2.0.0
.package(url: "/SwiftyJSON", from: "1.5.8"),
when, at least as far as I can tell, this:
// 1.5.8 ..< 2.0.0
.package(url: "/SwiftyJSON", .uptoNextMajor("1.5.8")),
does the same thing, and the spelling is, at least to me, clearer as well.
Dunno, maybe the “from” version is a term of art that I’m just not familiar
with.
> * Is the problem being addressed significant enough to warrant a change to
> the Swift Package Manager?
Yep
> * Does this proposal fit well with the feel and direction of Swift?
Yep
> * If you have used other languages, libraries, or package managers with a
> similar feature, how do you feel that this proposal compares to those?
N/A
> * How much effort did you put into your review? A glance, a quick reading, or
> an in-depth study?
Read the discussion thread and the proposal a few times.
- Dave Sweeris_______________________________________________
swift-evolution mailing list
[email protected]
https://lists.swift.org/mailman/listinfo/swift-evolution
