- What is your evaluation of the proposal? +1
- Is the problem being addressed significant enough to warrant a change to Swift? Yes - Does this proposal fit well with the feel and direction of Swift? Yes - If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those? I do not have significant experience with this feature in other languages - How much effort did you put into your review? A glance, a quick reading, or an in-depth study? A quick reading. On 31 March 2017 at 11:50, Rien via swift-evolution < [email protected]> wrote: > > • What is your evaluation of the proposal? > > +1 > > > > • Is the problem being addressed significant enough to warrant a > change to Swift? > > I do not see this as a problem, but as added functionality that would be > beneficial > > > > • Does this proposal fit well with the feel and direction of Swift? > > 100% > > > > • If you have used other languages or libraries with a similar > feature, how do you feel that this proposal compares to those? > > Yes, but this is actually better due to type safety > > > > • How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > > Quick reading. > > > One observation though: I feel that “PartialKeyPath” does not add > information, “partial” leaves one swimming: "what exactly is partial?”. > “RootKeyPath” would be more expressive imo. If RootKeyPath would be > unacceptable, I would still prefer “RelativeKeyPath” over “PartialKeyPath”. > > Regards, > Rien > > Site: http://balancingrock.nl > Blog: http://swiftrien.blogspot.com > Github: http://github.com/Balancingrock > Project: http://swiftfire.nl > > > > > > > On 30 Mar 2017, at 18:25, Douglas Gregor via swift-evolution < > [email protected]> wrote: > > > > Hello Swift community, > > > > The review of SE-0161 "Smart KeyPaths: Better Key-Value Coding for > Swift" begins now and runs through April 5, 2017. The proposal is available > here: > > > > https://github.com/apple/swift-evolution/blob/master/ > proposals/0161-key-paths.md > > Reviews are an important part of the Swift evolution process. All > reviews should be sent to the swift-evolution mailing list at > > > > https://lists.swift.org/mailman/listinfo/swift-evolution > > or, if you would like to keep your feedback private, directly to the > review manager. When replying, please try to keep the proposal link at the > top of the message: > > > > Proposal link: > > > > https://github.com/apple/swift-evolution/blob/master/ > proposals/0161-key-paths.md > > Reply text > > Other replies > > What goes into a review? > > > > The goal of the review process is to improve the proposal under review > through constructive criticism and, eventually, determine the direction of > Swift. When writing your review, here are some questions you might want to > answer in your review: > > > > • What is your evaluation of the proposal? > > • Is the problem being addressed significant enough to warrant a > change to Swift? > > • Does this proposal fit well with the feel and direction of Swift? > > • If you have used other languages or libraries with a similar > feature, how do you feel that this proposal compares to those? > > • How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > > More information about the Swift evolution process is available at > > > > https://github.com/apple/swift-evolution/blob/master/process.md > > Thank you, > > > > -Doug > > > > Review Manager > > > > _______________________________________________ > > swift-evolution mailing list > > [email protected] > > https://lists.swift.org/mailman/listinfo/swift-evolution > > _______________________________________________ > swift-evolution mailing list > [email protected] > https://lists.swift.org/mailman/listinfo/swift-evolution > -- *Pranshu Goyal* *iOS Developer* *tlkn*
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
