+1 The only comment I have is the mergingValues argument label for the closure passed in to the merge methods. My preference would be resolvingCollisionsWith:, i.e. merge(_:resolvingCollisionsWith:) and merged(with:resolvingCollisionsWith:).
> On Apr 5, 2017, at 8:45 PM, Ben Cohen via swift-evolution > <[email protected]> wrote: > > Hello, Swift community! > > The review of "SE-165: Dictionary & Set Enhancements" begins now and runs > through next Tuesday, April 11th. The proposal is available here: > > https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md > <https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md> > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > https://lists.swift.org/mailman/listinfo/swift-evolution > <https://lists.swift.org/mailman/listinfo/swift-evolution> > > or, if you would like to keep your feedback private, directly to the review > manager. When replying, please try to keep the proposal link at the top of > the message: > > Proposal link: > https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md > <https://github.com/apple/swift-evolution/blob/master/proposals/0165-dict.md> > > Reply text > > Other replies > > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and, eventually, determine the direction of > Swift. When writing your review, here are some questions you might want to > answer in your review: > > • What is your evaluation of the proposal? > • Is the problem being addressed significant enough to warrant a change > to Swift? > • Does this proposal fit well with the feel and direction of Swift? > • If you have used other languages or libraries with a similar feature, > how do you feel that this proposal compares to those? > • How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? > > More information about the Swift evolution process is available at > https://github.com/apple/swift-evolution/blob/master/process.md > <https://github.com/apple/swift-evolution/blob/master/process.md> > > Thank you, > > Ben Cohen > Review Manager > > > _______________________________________________ > swift-evolution mailing list > [email protected] > https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
