> On 6 Apr 2017, at 4:39 am, John McCall via swift-evolution > <[email protected]> wrote: > > Hello, Swift community! > > The review of "SE-163: String Revision: Collection Conformance, C Interop, > Transcoding" begins now and runs through next Tuesday, April 11th. The > proposal is available here: > > https://github.com/apple/swift-evolution/blob/master/proposals/0163-string-revision-1.md > > <https://github.com/apple/swift-evolution/blob/master/proposals/0163-string-revision-1.md> > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > https://lists.swift.org/mailman/listinfo/swift-evolution > <https://lists.swift.org/mailman/listinfo/swift-evolution> > or, if you would like to keep your feedback private, directly to the review > manager. When replying, please try to keep the proposal link at the top of > the message: > > Proposal link: > https://github.com/apple/swift-evolution/blob/master/proposals/0155-normalize-enum-case-representation.md > > <https://github.com/apple/swift-evolution/blob/master/proposals/0155-normalize-enum-case-representation.md> > > Reply text > > Other replies > > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and, eventually, determine the direction of > Swift. When writing your review, here are some questions you might want to > answer in your review: > > • What is your evaluation of the proposal?
+1. (If I could +100, I would). Great start to the string overhaul. > • Is the problem being addressed significant enough to warrant a change > to Swift? Yes. Aligns the string model much closer to the mental model we manipulate strings with. > • Does this proposal fit well with the feel and direction of Swift? Yes. Its a tidier and more consistent implementation of what ultimately ends up being a convoluted collection of characters. > • If you have used other languages or libraries with a similar feature, > how do you feel that this proposal compares to those? Some experience with C++ and lots of experience with Swift 1, 2 and Obj-C Strings. This brings Swift String back to the consistent logical clarity it had in Swift 1. > • How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? Quick reading, following Swift String discussions, etc. > > More information about the Swift evolution process is available at > https://github.com/apple/swift-evolution/blob/master/process.md > <https://github.com/apple/swift-evolution/blob/master/process.md> > > Thank you, > > John McCall > Review Manager > _______________________________________________ > swift-evolution mailing list > [email protected] > https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
