Review of SE-0169 "Improve Interaction Between private Declarations and Extensions"
What is your evaluation of the proposal? Yes. Would prefer Swift 2 model but given that that is rejected this is a good compromise. Is the problem being addressed significant enough to warrant a change to Swift? Debatable. I have got used to fileprivate (I don't bother with private!) Does this proposal fit well with the feel and direction of Swift? Yes. Extensions are needed/preferred in many cases in Swift. If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those? Yes Scala has fine grained privacy. However I don't use the facilities much in practice, preferring to extend visibility beyond the strict minimum for the sake of simplicity. How much effort did you put into your review? A glance, a quick reading, or an in-depth study? Not a lot. Quick read. -- Howard. > On 7 Apr 2017, at 9:10 am, Douglas Gregor <[email protected]> wrote: > > The review of SE-0169 "Improve Interaction Between private Declarations and > Extensions" begins now and runs through April 11, 2017. The proposal is > available here: > > https://github.com/apple/swift-evolution/blob/master/proposals/0169-improve-interaction-between-private-declarations-and-extensions.md > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > > https://lists.swift.org/mailman/listinfo/swift-evolution > or, if you would like to keep your feedback private, directly to the review > manager. When replying, please try to keep the proposal link at the top of > the message: > > Proposal link: > > https://github.com/apple/swift-evolution/blob/master/proposals/0169-improve-interaction-between-private-declarations-and-extensions.md > Reply text > Other replies > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and, eventually, determine the direction of > Swift. When writing your review, here are some questions you might want to > answer in your review: > > What is your evaluation of the proposal? > Is the problem being addressed significant enough to warrant a change to > Swift? > Does this proposal fit well with the feel and direction of Swift? > If you have used other languages or libraries with a similar feature, how do > you feel that this proposal compares to those? > How much effort did you put into your review? A glance, a quick reading, or > an in-depth study?
_______________________________________________ swift-evolution mailing list [email protected] https://lists.swift.org/mailman/listinfo/swift-evolution
