> On Nov 16, 2017, at 2:23 PM, Ted Kremenek via swift-evolution > <swift-evolution@swift.org> wrote: > > When reviewing a proposal, here are some questions to consider: > > What is your evaluation of the proposal? > I think the functionality is good, but I would like to see some thought on what future values could be to see if this is the best name/structure.
If it is just going to be the concept of a simulator, then something like isSimulated() might be better. In the current form, I think we should have both ‘Simulator’ and ‘Device’ as options. I would also like to see something shorter than targetEnvironment(), but it is somewhat infrequently used, so it isn’t that big a deal. It is just compared to os() and arch(), this is kind of a beast. It is a power user thing, so maybe something like ‘env()’ would work? I normally try to avoid abbreviations, but we have arch() as precedent. The word ‘Simulator’ should be what stands out... Would Testing be a possible future environment? > Is the problem being addressed significant enough to warrant a change to > Swift? > Yes, Definitely! > Does this proposal fit well with the feel and direction of Swift? > Yes. > If you have used other languages or libraries with a similar feature, how do > you feel that this proposal compares to those? > I guess Objective C had something like this as well, which was more powerful, but also more messy. > How much effort did you put into your review? A glance, a quick reading, or > an in-depth study? > Quick Read
_______________________________________________ swift-evolution mailing list swift-evolution@swift.org https://lists.swift.org/mailman/listinfo/swift-evolution
