Hello Alexander, > The fix looks good, > I see no reasons why not to push it to openJDK 6
Thanks. I suppose you mean JDK7? > I filed an RFE > #6759311 RepaintManager casts Tookit to SunToolkit without instanceof check > > It usually requires a couple of days for CR to appear in the public database > > If you would like to push to the workspace yourself, > you are welcome I can do that, thanks :-) I propose the following Changeset comment: 6759311: RepaintManager casts Tookit to SunToolkit without instanceof check Summary: Check type of Toolkit before casting. Reviewed-by: alexp If this is ok, then I'll push it to the gate ASAP. Thanks and cheers, Roman > > alexp > > > > > /Roman > > > > Am Dienstag, den 16.09.2008, 10:54 +0200 schrieb Roman Kennke: > >> Hello, > >> > >> The attached patch fixes two problems in RepaintManager. The first one > >> is a direct cast from Toolkit to SunToolkit, without checking for the > >> actual type, the second is using a SunToolkit static method without > >> checking if we are actually using a SunToolkit. This makes it impossible > >> to use a non-SunToolkit as AWT backend. The solution in the first case > >> is to check for SunToolkit (of course) and in the 2nd case to also check > >> for SunToolkit, and using a different method to post event to the EQ. > >> This patch was developed as part of the Caciocavallo project and it > >> would be good to have it merged it into mainline. What do you think? > >> > >> /Roman > >> > -- Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-48 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Geschäftsführer: Dr. James J. Hunt
