yes.
-phil.
On 8/24/2010 7:35 AM, Omair Majid wrote:
Hi Phil,
On 08/23/2010 05:44 PM, Phil Race wrote:
Looks fine. Sorry for the slow reply, I just got back from vacation.
-phil.
Thanks for looking over the changes. Can I go ahead and commit them?
Cheers,
Omair
On 8/13/2010 8:07 AM, Omair Majid wrote:
Hi Phi,
Sorry to bother you, but in case you missed the original email, I have
an updated patch that follows your suggestions. I would really
appreciate it if you could take a look at it.
http://cr.openjdk.java.net/~omajid/webrevs/gtk-floating-point-font-size-support/webrev.01/
Thanks,
Omair
On 08/06/2010 04:43 PM, Omair Majid wrote:
Hi Phil,
On 08/05/2010 05:47 PM, Phil Race wrote:
There's two public API changes in here and you can get away without
either of them.
So I believe you wouldn't need the changes in SunFontManager,
FontUIResource, or Font.java
Eg in PangoFonts you can write something like :
Font f = new Font(family, style, ((int)dsize+0.5));
f = f.deriveFont((float)dsize); // already public API
FontUIResource fuir = new FontUIResource(f); // already public API
And something similar would need to be done in FontUtilities
The two extra font objects that are created really will not matter
as a
Font
is a small object and its lazily mapped to a real font.
-phil.
Thank you very much for your feedback.
Here is an updated webrev that does things the way you suggested:
http://cr.openjdk.java.net/~omajid/webrevs/gtk-floating-point-font-size-support/webrev.01/
Thanks,
Omair
