On 08/30/2011 07:17 PM, Pavel Porvatov wrote:
Hi Charles,
On 08/25/2011 05:45 PM, Pavel Porvatov wrote:
Hi Charles,
On 07/26/2011 08:58 PM, Charles Lee wrote: Hi guys,
Could some one take some to look at this patch?
I took a look at the patch and have several comments:
1. There is no AccessibleDescription for all resources, therefore
I'd prefer to remove filesAccessibleDescription
2. Please follow our code conventions
http://www.oracle.com/technetwork/java/codeconvtoc-136057.html
a.
private String filesListAccessibleName=null;
=>
private String filesListAccessibleName = null;
b. Don't use TABs characters at all
c.
filesListAccessibleName
=UIManager.getString("FileChooser.filesListAccessibleName",l);
=>
filesListAccessibleName =
UIManager.getString("FileChooser.filesListAccessibleName", l);
etc.
3. As in the last CR fixing you should add the same resources to all
basic_XX.properties files
4. Why don't you use
putClientProperty(AccessibleContext.ACCESSIBLE_NAME_PROPERTY,
accessibleName) instead of "javax.accessibility.AccessibleContext
ac=list.getAccessibleContext();......"
Regards, Pavel
Hi Pavel,
I have modified the patch (attached) according to your comments.
Sorry I can not use putClientProperty because it does not work :-)
Thanks Pavel, please see some comments below.
I took a look at the patch and have several comments:
1. There is no AccessibleDescription for all resources, therefore I'd
prefer to remove filesAccessibleDescription
I do not get it ...
2. Please follow our code conventions. Space is needed after commas
in args:
filesListAccessibleName =
UIManager.getString("FileChooser.filesListAccessibleName",l);
=>
filesListAccessibleName =
UIManager.getString("FileChooser.filesListAccessibleName", l);
Sorry, I will change it.
3. "Sorry I can not use putClientProperty because it does not work
:-)". I've checked that it works
Whoops. I will try it in some other ways.
4. It seems to complete fix we should add Accessible Name for JTable
in the FilePane#createDetailsView method
BTW: do you have a case where you need accessible name for JList from
JFileChooser?
scout.jar. Is that the case you want?
Regards, Pavel
--
Yours Charles
