On Thu, 2011-09-15 at 17:04 +0400, Pavel Porvatov wrote: > Hi Neil, > > On Wed, 2011-09-14 at 14:14 +0800, Sean Chou wrote: > >> Hi Pavel, > >> > >> > >> I reported a bug there yesterday, > >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7089914 > >> So far, I'm not sure if Windows use ControlTextColor, I'll check > >> it. > >> > > For ease of review, I've uploaded Sean's change as a webrev [1]. > > > > With the change, I see the following focus-related color settings in the > > WindowsLookAndFeel: > > > > Button.focus: ControlTextColor > > Checkbox.focus: ControlTextColor > > RadioButton.focus: ControlTextColor > > Slider.focus: ControlDarkShadowColor > > TabbedPane.focus: ControlTextColor > > ToggleButton.focus: ControlTextColor > > > > So the change of setting for Button, Checkbox and RadioButton conforms > > to what is already used for TabbedPane and ToggleButton. > But doesn't conform to Slider.focus...
Are you recommending that Slider.focus should be changed to ControlTextColor too ? > > > > From it's name, it's not entirely obvious to me that 'ControlTextColor' > > is really the ideal setting to use here, but it's also clear that it's a > > far better setting to use than the current hard-coded 'black'. > Yes, of course. The last question is which color is correct. We can't > change one incorrect color to another incorrect color... I guess I hope that some knowledgeable person might be able to suggest / corroborate / refute the choice of setting here. It seems worse to consider sticking with a hard-coded, un-configurable value that has been demonstrated to cause problems, than to use a setting whose value can at least be configured, in practice fixes the problem's symptoms, and is already used in most other similar contexts within the same look & feel. Suggestions for how to improve things further are always welcome. Regards, Neil -- Unless stated above: IBM email: neil_richards at uk.ibm.com IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
