Re: Request review for 7129742 : Unable to view focus in Non-Editable TextArea

[Alexander Potochkin]

Hello Sean

Thanks for the details
The fix looks good for me!

alexp

Hi Alexander,

XTextFieldPeer and XTextAreaPeer have a same inner class XAWTCaret, and in XTextAreaPeer there is also a comment: "// TODO : fix this duplicate code " before XAWTCaret . So I removed the XAWTCaret in XTextFieldPeer and changed the XAWTCaret into a static class, so XTextFieldPeer can use XAWTCaret from XTextAreaPeer .

As XAWTCaret is only used in the following method in both XTextAreaPeer and XTextFieldPeer .

protected Caret createCaret() {
 return new XAWTCaret();
 }
    I think this modification should not bring side effect.

On Mon, Mar 12, 2012 at 1:27 AM, Alexander Potochkin <alexander.potoch...@oracle.com <mailto:alexander.potoch...@oracle.com>> wrote:

    Hello Sean

    Could you give more details about your changes in XTextFieldPeer?

    Thanks
    alexp

        Hi all,

          I updated the patch to as suggested and simplified the
        testcase .
        Would anyone like to take a look again ? Thanks.

         The webrev is at :
        http://cr.openjdk.java.net/~zhouyx/7129742/webrev.04/
        <http://cr.openjdk.java.net/%7Ezhouyx/7129742/webrev.04/>
        <http://cr.openjdk.java.net/%7Ezhouyx/7129742/webrev.04/>


         Previous discussion at :
        
http://mail.openjdk.java.net/pipermail/swing-dev/2012-February/001913.html

-- Best Regards,

        Sean Chou





--
Best Regards,
Sean Chou