Hi Charles,
On 03/21/2012 09:15 PM, Pavel Porvatov wrote:
Hi Charles,
Hi guys,
I am trying to fix 7026933 and 4310381.
Patch @ http://cr.openjdk.java.net/~littlee/7026933/webrev.00/
<http://cr.openjdk.java.net/%7Elittlee/7026933/webrev.00/>
The test case is @ 4310381 and 7026933.
My patch fix the padding problem on all the tabs except the top tab.
The reason about this is Metal look and feel does not want to pad
the last one. Please check the code in MetalTabbedPaneUI:
// Don't pad last run
protected boolean shouldPadTabRun( int tabPlacement, int run ) {
return runCount > 1 && run < runCount - 1;
}
Does anyone has some knowledge about this? If metal does not want
pad that tab, my patch should be consider fixing the problem :-)
That strange line was introduced with fix of CR 4253906 (since 1999).
Looks strange indeed...
The fix looks good for me. What about a test? I'm not sure automatic
test is possible here, so you can write manual test...
Regards, Pavel
Hi Pavel,
Test case is attached. I am trying to make it in the webrev, but I am
not quite understand "@run ****/manual=******". Should I use
applet/manual? Should I provide a bug7026933.html?
PS:
CR 4253906 does not have enough info......
I rewrote your test and committed the changes:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/1dd6fe680681
Thanks for your contribution!
Regards, Pavel
