Hi Neil,
Hi Sean,
I see from the OpenJDK census [1] that Alexandr is a "Committer" to the
jdk8 project [2], whilst a "Reviewer" needs to approve the change for it
to move forward.
As Pavel is a Reviewer for jdk8 [3] and has already been involved in
reviewing this contribution, I suggest he might be the best person to
endorse the change.
Pavel: are you happy with Sean's latest version of the change [4] ?
Yes, the fix looks good for me now. I was on vacation, so Alexandr
helped to complete the review.
Regards, Pavel
[1] http://openjdk.java.net/census
[2] http://openjdk.java.net/census#alexsch
[3] http://openjdk.java.net/census#rupashka
[4] http://cr.openjdk.java.net/~zhouyx/OJDK-61/webrev.09/
On Thu, 2012-09-20 at 15:40 +0800, Sean Chou wrote:
Hi Alexander,
May I find some one to commit it ?
On Tue, Sep 18, 2012 at 10:34 PM, Alexander Scherbatiy
<[email protected]> wrote:
Hi Sean,
The fix and test look good for me.
I think that there are areas for improvements like initialization the selRow
and selCol variables to the color coordinates defined in the constructor
(new JColorChooser(Color.GREEN)). However it is not necessary for this fix.
Thanks,
Alexandr.
On 9/17/2012 10:28 AM, Sean Chou wrote:
Hi Pavel,
The new webrev is at:
http://cr.openjdk.java.net/~zhouyx/OJDK-61/webrev.09/ .
The missed sync is added.
On Sat, Sep 15, 2012 at 12:41 AM, Pavel Porvatov
<[email protected]> wrote:
Hi Sean,
Hi Pavel,
Thank you very much for testing on MacOS, I have windows and linux only
for now.
The new patch is at:
http://cr.openjdk.java.net/~zhouyx/OJDK-61/webrev.08/ .
Your version of the test is wrong. Why did you remove realSync before
hitting keys? It's possible that invokeLater with
recentSwatchPanel.requestFocusInWindow will be executed AFTER all keys are
pressed and the test will fail... Moreover requestFocusInWindow invocation
doesn't guarantee that recentSwatchPanel has focus because of javadoc:
* Developers must never
* assume that this Component is the focus owner until this
* Component receives a FOCUS_GAINED event.
Regards, Pavel.
