Re: [8] Review request for 8000969 [macosx] Directories are not deselected when JFileChooser has FILES_ONLY selection mode

[pavel porvatov]

Hi Alexander,

Looks good for me.

Regards, Pavel

Could you review the updated fix:
  http://cr.openjdk.java.net/~alexsch/8000969/webrev.01/

The "fileChooser.getFileSelectionMode() == JFileChooser.FILES_ONLY" check is changed to "!fileChooser.isDirectorySelectionEnabled()".

Thanks,
Alexandr.


On 10/16/2012 5:29 PM, pavel porvatov wrote:

Hi Alexander,

Could you please use "!JFileChooser#isDirectorySelectionEnabled()" instead of "fileChooser.getFileSelectionMode() == JFileChooser.FILES_ONLY"? Other part of the fix looks good for me.

Regards, Pavel

bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000969
webrev: http://cr.openjdk.java.net/~alexsch/8000969/webrev.00/

The fix deselects directories when the a JFileChooser has FILES_ONLY selection mode.

The the DIRECTORIES_ONLY selection mode disables files so it is necessary to do nothing in this case.

Thanks,
Alexandr.