Thank you, Anton. The comment looks fine to me (and so does the fix).
--
best regards,
Anthony
On 12/5/2012 8:53 PM, Anton Litvinov wrote:
Hello Anthony,
Thank you for the review of this fix. The corresponding comment was
added to the bug's page. Unfortunately it is not available on the public
bug report yet for the reason of synchronization delay. A copy of this
comment is provided below.
Comment:
It was learnt that incomplete support of serialization by "Mac OS X"
look and feel (L&F) is a renowned issue, because of which JDK passes all
JCK tests on OS X only with "Metal" L&F. "Metal" L&F is a cross-platform
L&F, which is default for any Java application, therefore all Swing
regression tests which are not related to another particular L&F, are
written for "Metal" implicitly. Since only JDK for OS X changes "Metal"
for "Mac OS X" by default, explicit setting of "Metal" L&F could be an
acceptable workaround for correction of this test.
Thank you,
Anton
On 12/5/2012 2:39 PM, Anthony Petrov wrote:
Hi Alexander,
This sounds reasonable. Thanks for the clarification.
Could this evaluation be added as a comment to the bug report, so that
it would be clear to anyone why the fix simply works around the
problem rather than resolves the underlying issue?
--
best regards,
Anthony
On 12/5/2012 2:40 PM, Alexander Potochkin wrote:
Hello Anthony
Hi Anton,
This fix seems to resolve the test failure, but not the bug itself.
Do you think it makes sense to investigate why the Mac OS X L&F
isn't serializable, and perhaps make it serializable so that the
test passes w/o any modifications?
Let me answer this question.
It is a known issue that AquaLaF doesn't support serialization.
When we integrated this code to our repository
I did a research and found that it is too complex and risky to fix,
moreover since it works the same way for JDK6 (and no one complained)
there is no business reason for doing that.
Historically all Swing tests that are not related to a specific LaF
are written for Metal.
Since only Mac JDK sets its own LaF by default,
the explicit setting of Metal is expected in this test.
Thanks
alexp
--
best regards,
Anthony
On 12/5/2012 1:33 PM, Anton Litvinov wrote:
Hello,
Please review the following fix for a bug.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003982
Webrev: http://cr.openjdk.java.net/~alitvinov/8003982/webrev.00
This bug consists in malfunctioning of serialization mechanism for
Swing components in "Mac OS X" look and feel (L&F), which is used
by default, when this test case is run on OS X operating system.
Explicit setting of "Metal" L&F resolves this bug.
Thank you,
Anton
