The fix looks good for me.
Thanks,
Alexandr.
On 1/22/2013 9:07 PM, Sergey Malenkov wrote:
Hi Sergey,
After the discussion offline we decided to fix the WindowsPlacesBar
class instead of the API-related change.
Could you please review the following fix:
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6817933
fix: http://cr.openjdk.java.net/~malenkov/6817933.1/
I removed HTML-based text from the JToggleButton. The automatic test
is included.
Thanks,
SAM
On 21.01.2013 15:11, Sergey Bylokhov wrote:
Hi, Sergey
Not sure that this change correspond to documentation:
"
373 /**
374 * Get the set of styles currently being used to render the
375 * HTML elements. By default the resource specified by
376 * DEFAULT_CSS gets loaded, and is*shared* by all
HTMLEditorKit
377 * instances.
378 */
"
What does it mean: "shared"?
21.01.2013 14:40, Sergey Malenkov wrote:
Hello,
Could you please review the following fix:
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6817933
fix: http://cr.openjdk.java.net/~malenkov/6817933.0/
The styleSheet property of the HTMLEditorKit class have a static
behavior. It must be non-static because of JavaBeans spec. The
automatic test is included.
Thanks,
SAM
