Re: [8] Request for approval for CR 7105119 - [TEST_BUG] [macosx] In test UIDefaults.toString() mast be called with the invokeLater()

[Alexander Scherbatiy]

On 2/13/2013 5:30 PM, Konstantin Shefov wrote:

On 13-Feb-13 15:52, Alexander Scherbatiy wrote:

On 2/12/2013 6:37 PM, Konstantin Shefov wrote:

Hello,

Please review a fix for the issue:

7105119 - [TEST_BUG] [macosx] In test UIDefaults.toString() mast be called with the invokeLater()

The webrev is http://cr.openjdk.java.net/~kshefov/7105119/webrev.00/

Could you give more information why the UIDefaults.toString() needs to be called with the invokeLater()? The UIDefaults.toString() has explicit synchronized keyword and the UIManager.getDefaults() method uses classLock object for synchronization.

Indeed.

I do not know, why this test hanged on mac, most probably jtreg issue. Without jtreg it passed ok. With invokeLater() it passed with JTREG also.

Anyway, I have suggest to convert this test to JTREG main test, because the parent bug 4300666 does not depend on applet execution:

http://cr.openjdk.java.net/~kshefov/7105119/webrev.01

After conversion, the test works fine on Mac and other OSs.

      The fix looks good for me.

     Thanks,
     Alexandr.

-Konstantin

   Thanks,
   Alexandr.

Thanks,
Konstantin