Re: [8] Review request for 6877495 JTextField and JTextArea does not support supplementary characters

Tue, 05 Mar 2013 04:24:32 -0800 


Hello Mikhail

From the Swing point of view it looks good, I approve.

However I would recommend sending the fix to 2D alias as well,
since they know much more about UTF.

Thanks
alexp


Hi Everyone,

This is just friendly reminder about this review request.

Thanks,
Mikhail.

On 20.02.2013 19:29, Alexander Scherbatiy wrote:


  Hello,

  Could you review the updated patch:
   http://cr.openjdk.java.net/~alexsch/6877495/webrev.01/

  The fix is unchanged. Only test is added.
Copying and pasting a string from the same Java process does not help because necessary DataTransferer class is not created in this case. 
  The other possibility is to copy a text from a separated started JVM.
The test in the fix extends DataTransferer class to create ReencodingInputStream and use read() method from it. 

  Thanks,
  Alexandr.

On 2/18/2013 1:53 PM, Sergey Bylokhov wrote:

Hi, Alexander.
Fix looks good, but testcase will be welcome.
15.02.2013 17:40, Alexander Scherbatiy wrote:


Hello,

Could you review the fix, contributed by the NetBeans user:
  http://netbeans.org/bugzilla/show_bug.cgi?id=164820

bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6877495
webrev: http://cr.openjdk.java.net/~alexsch/6877495/webrev.00
The DataTransferer logic is updated to handle supplementary characters. 

Thanks,
Alexandr.

Reply via email to