Hi, Alexander.
Fix looks good, except code formatting:
-if(!Objects.equals(oldValue, tipText)){
+if (!Objects.equals(oldValue, tipText)) {
and new empty line 137 can be removed.
Not necessary to send additional webrev.
On 23.05.2013 15:02, Alexander Scherbatiy wrote:
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8014924/webrev.01/
The Objects.equals() method is used for the string comparison.
Thanks,
Alexandr.
On 5/22/2013 7:36 PM, Sergey Bylokhov wrote:
Hi, Alexander.
Why it is necessary to call revalidate if string was changed from
null to null?
Why not just use !Objects.equals(tipText, oldValue)?
On 22.05.2013 17:48, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014924
webrev: http://cr.openjdk.java.net/~alexsch/8014924/webrev.00
The fix adds missed revalidate() and repaint() methods to the
JToolTip.setTipText() method.
Thanks,
Alexandr.
--
Best regards, Sergey.
