Hello Alexander,
Thank you for the review of this fix. Could you please review a new
version of the fix, which was changed according to your remarks. The
file name of the regression test was changed to "bug6337518.java" and
the test was moved to "test/javax/swing/JComboBox" directory.
Webrev: http://cr.openjdk.java.net/~alitvinov/6337518/webrev.01
Thank you,
Anton
On 5/31/2013 9:14 PM, Alexander Potochkin wrote:
Hello Anton
The fix and the test look good,
only a minor comment
It is a common practice to name the new Swing tests like this:
/ComponenetName/bugNumber/bugNumber.java
I think it makes sense to follow the known pattern,
so could you rename**NPEOnInstallComponentsTest folder to "6337518"
by the way, you can safely put the new test under the JComboBox folder
to avoid creating the new one (but this is up to you)
Thanks
alexp
On 5/31/2013 8:03 PM, Anton Litvinov wrote:
Hello,
Please review the following fix for a bug.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6337518
Webrev: http://cr.openjdk.java.net/~alitvinov/6337518/webrev.00
This bug consists in throwing of NullPointerException from the method
"javax.swing.plaf.basic.BasicComboBoxUI.installComponents()", if
"createArrowButton()" method returns null. The solution moves code
generating this exception into a body of an already existing "if"
block which checks the result of a call to "createArrowButton()"
method for null.
Thank you,
Anton
