> OK, the fix is fine (despite the webrev doesn't look fine:))
But this webrev shows that nothing changed (except EOLNs ;).
The resulting diff is much worse:
http://hg.openjdk.java.net/jdk8/awt/jdk/rev/bf80c2965a84
Thanks,
SAM
On 29.07.2013 17:57, Artem Ananiev wrote:
OK, the fix is fine (despite the webrev doesn't look fine:))
Thanks,
Artem
On 7/18/2013 6:52 PM, sergey malenkov wrote:
Webrev is always empty, because "-b" affects only whitespaces, but I
removed all ^M.
Seems it is a problem of the Mercurial's diff.
SAM
On 18.07.2013 18:34, Artem Ananiev wrote:
What a nice "empty" webrev :) Could you generate the new version, with
"-b" (do not ignore whitespaces) passed to the webrev script, please?
Hope it helps to reveal the real changes.
Thanks,
Artem
On 7/17/2013 6:19 PM, sergey malenkov wrote:
Hello,
Could you please review the following fix:
fix: http://cr.openjdk.java.net/~malenkov/8010782.8.0/
<http://cr.openjdk.java.net/%7Emalenkov/8010782.8.0/>
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010782
I removed all ^M at the end of lines.
Thanks,
SAM
