Looks good to me. Leonid.
On 08.10.2013, at 14:57, Alexander Scherbatiy <alexandr.scherba...@oracle.com> wrote: > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8005391 > webrev: http://cr.openjdk.java.net/~alexsch/8005391/webrev.00 > > The test in the webrev fails because SimpleAttributeSet returns attribute > names as Hashtable keys which order is not preserved. > So the tags are also generated in the random order. > > The suggested fix uses LinkedHashMap instead of Hashtable which guarantee > predictable iteration order. > > The LinkedHashMap implementation is not synchronized as it is done for the > Hashtable. > However, the SimpleAttributeSet is designed to use on EDT like others swing > classes. > > Thanks, > Alexandr. >
