Re: [9] Review request: 8028616 Htmleditorkit parser doesn't handle leading slash (/)

Tue, 14 Jan 2014 00:15:48 -0800 


  The fix looks good for me.

  Thanks,
  Alexandr.

On 1/13/2014 2:23 PM, dmitry markov wrote:

Hello Alexandr,
Thank you for the review. I updated the test as you suggested. Please find new version here - http://cr.openjdk.java.net/~dmarkov/8028616/jdk9/webrev.01/ 

Thanks,
Dmitry

On 10/01/2014 17:12, Alexander Scherbatiy wrote:
It would be good to check the data and position in the handleText callback in the test and pass the test immediately if the check in the handleText is correct. 
  Otherwise, the fix looks good for me.

  Thanks,
  Alexandr.


On 1/10/2014 3:06 PM, dmitry markov wrote:

Hello,

Could you review the fix for jdk9, please?

    bug: https://bugs.openjdk.java.net/browse/JDK-8028616
    webrev: http://cr.openjdk.java.net/~dmarkov/8028616/jdk9/webrev.00/
The method Parser.parseContent() should invoke legalElementContext(), if the parsed text is not wrapped by tags and starts with slash (/). 

Thanks,
Dmitry

Reply via email to