Hi, Alexander.
Why the change in the BasicSpinnerUI is required? Can we call a
revalidate/repaint in the JSpinner.setComponentOrientation()?
Note that JSpinner is a JComponent which is Container, so when you call
applyComponentOrientation on it you apply new orientation to the whole
JSpinner hierarchy, and it looks wrong.(I know that it is unlikely).
On 23.01.2014 19:06, Alexander Scherbatiy wrote:
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8008657/webrev.01
- revalidate()/repaint() is added after component orientation
applying in the same way as it is done for the JTextFiled
- there is one more issue that a text in the Number editor should
stick to the arrows. It is fixed in the NumberEditor class.
Thanks,
Alexandr.
On 1/22/2014 6:00 PM, Sergey Bylokhov wrote:
Hello, Alexander.
Is updateUI needed to fix the problem? Since
applyComponentOrientation calls invalidateIfValid anyway.
On 20.01.2014 17:50, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8008657
webrev: http://cr.openjdk.java.net/~alexsch/8008657/webrev.00
The "componentOrientation" property change event should be
propagated to the JSpinner editor component.
Thanks,
Alexandr.
--
Best regards, Sergey.
