Hi, Alexander.
The fix looks good.

On 2/24/14 5:35 PM, Alexander Scherbatiy wrote:

 Hello,

Could you review the backport of the fix to JDK 8u20?

 Thanks,
 Alexandr.

On 2/4/2014 8:15 PM, Alexander Scherbatiy wrote:

Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8010718
  webrev: http://cr.openjdk.java.net/~malenkov/8022398.8.0

This is the original fix for the issue 8022398 Use one FilterComboBoxModel for all L&Fs. The general refactoring for the fix 8022398 has been reverted back because of the issue 8032063 javax.swing.plaf.metal.MetalFileChooserUI$FilterComboBoxModel extends non-standard API

The FilterComboBoxModel from AquaFileChooserUI calls clear() during choosable file filter changed event
which leads setting to null the JFileChooser fileFilter.

FilterComboBoxModels from other FileChooserUI does not have this issue.
The fix reuses the standard FilterComboBoxModel implementation from other L&Fs.

See the original discussion: http://mail.openjdk.java.net/pipermail/swing-dev/2013-August/002860.html

Thanks,
Alexandr.




--
Best regards, Sergey.

Reply via email to