Re: Review request for JDK-8042089: Fix doclint warnings from javax.swing.tree and javax.swing.undo packages

Mon, 19 May 2014 00:50:17 -0700 

Alexander,
Thanks for review!

-dima

On 15.05.2014 19:17, Alexander Scherbatiy wrote:


  The fix looks good for me.

  Thanks,
  Alexandr.

On 5/14/2014 4:59 PM, Dmitriy Ermashov wrote:

Hi,

Please review the changeset for:
https://bugs.openjdk.java.net/browse/JDK-8042089

Webrev is here:
http://cr.openjdk.java.net/~yan/8042089/webrev.01/
It is a fix for doclint warnings in javadoc. Added tags @param and @return to methods. 

Last changes:
1. Changed params description in DefaultTreeSelectionModel.notifyPathChange() method 

Thanks,
Dima

On 04/30/2014 07:07 PM, Alexander Scherbatiy wrote:

src/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java
---------------------------------
+     *
+     * @param changedPaths      the vector of the changed patches
+     * @param oldLeadSelection  the old selection index
      */
---------------------------------
The oldLeadSelection parameter has TreePath type and the index usually relates to an integer value. 

Thanks,
Alexandr.


On 4/29/2014 1:29 PM, Dmitriy Ermashov wrote:

Hi,

Please review the changeset for:
https://bugs.openjdk.java.net/browse/JDK-8042089

Webrev is here:
http://cr.openjdk.java.net/~yan/8042089/webrev.00/

For Alexander Potochkin and Alexandr Scherbatiy:
Guys, could you add me to subscription list swing-dev@openjdk.java.net?

Reply via email to