Hello, Steve.
A couple of comments:
1. CellRendererPane:192 - I've never seen that we write one-liner javadoc.
May be it's better to split it into 3 lines to conform to the common
pattern?
2. DefaultDesktopManager:480 - "iconifyFrame()" is definetely a candidate to
add @code tag
line 603 - you have an extra space before "the"
3. InputMap:78 - extra space
line 91: the javadoc comment "an Object" is quite useless. You could add
something like "an action map key"
4. JEditorPane: 1256 as you are updating the doc for this method, could you
please also update this line to also use @code
5. JFileChooser:2005 the one-liner javadoc
6. JMenu: 764 strange alignment of the block.
With best regards. Petr.
On 19 июня 2014 г., at 3:34, Steve Sides <[email protected]> wrote:
> Hello,
>
> Could you please review the fix for the following bug:
> https://bugs.openjdk.java.net/browse/JDK-8046590
>
> Webrev corresponding: (there were a couple typos in rev 1)
> http://cr.openjdk.java.net/~ssides/8046590/8046590.2/
>
> This addresses missing @parm and @return block tags in javadoc for
> javax/swing classes as noted by doclint and some reformatting.
>
> thanks,
>
> -steve
>
