Thanks for review!
Andrei
On 07/10/2014 05:18 PM, Petr Pchelko wrote:
Hello, Andrei.
The fix looks good.
With best regards. Petr.
On 10 июля 2014 г., at 17:12, andrei.eremeev <[email protected]> wrote:
Ok.
http://cr.openjdk.java.net/~yan/8049808/webrev.02/
Andrei
On 07/10/2014 05:05 PM, Petr Pchelko wrote:
Fixed.
No you didn't :)
http://cr.openjdk.java.net/~yan/8049808/webrev.01/
Looks like you've uploaded the exact same webrev.
With best regards. Petr.
On 10 июля 2014 г., at 16:58, andrei.eremeev <[email protected]> wrote:
Fixed.
http://cr.openjdk.java.net/~yan/8049808/webrev.01/
Andrei
On 07/10/2014 04:03 PM, Petr Pchelko wrote:
Hello, Andrei.
BasicBorders:353 - typo, the constructor constructs and not draws.
BasicBorders:442 - need an empty line
BasicListUI - what the {JList} construct is intended to mean? You forgot @code?
BasicListUI:247 - forgot @code
BasicListUI:1621 - same here
BasicMenuItemUI:481 @return what?
With best regards. Petr.
On 10 июля 2014 г., at 15:29, andrei.eremeev <[email protected]> wrote:
Hi Swing team,
Please, review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8049808
The fix is available at:
http://cr.openjdk.java.net/~yan/8049808/
Andrei
