Hi, Alexander.
The fix looks good.

On 10.07.2014 18:58, Alexander Scherbatiy wrote:

Could you review the updated version:
   http://cr.openjdk.java.net/~alexsch/8049533/webrev.02/

The xAbs and yAbs fields are also copied in the LWComponentPeer.createDelegateEvent() and ResizeBox.mouseWheelMoved() methods.

  Thanks,
  Alexandr.

On 7/10/2014 6:45 PM, Petr Pchelko wrote:
Hello, Alexander.

The .01 version looks good.

With best regards. Petr.

On 10 июля 2014 г., at 18:32, Alexander Scherbatiy <[email protected]> wrote:

Could you review the updated fix:
    http://cr.openjdk.java.net/~alexsch/8049533/webrev.01

The preciseWheelRotation field is copied in the LWComponentPeer.createDelegateEvent() and ResizeBox.mouseWheelMoved() methods.

Thanks,
Alexandr.

On 7/10/2014 2:34 PM, Sergey Bylokhov wrote:
Hi, Alexander.
Same fix should be applied to LWComponentPeer.createDelegateEvent(), and probably to ResizeBox.mouseWheelMoved. Please check all place where getWheelRotation is used.

On 10.07.2014 14:21, Alexander Scherbatiy wrote:
Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8049533
  webrev: http://cr.openjdk.java.net/~alexsch/8049533/webrev.00


The preciseWheelRotation field copying is missed in the SwingUtilities.convertMouseEvent(...) method.

Thanks,
Alexandr.





--
Best regards, Sergey.

Reply via email to