Hi, Alexander.
The fix looks good.

On 23.07.2014 16:52, Alexander Scherbatiy wrote:
On 7/22/2014 8:46 PM, Sergey Bylokhov wrote:
Hi, Alexander.
Should we update  BasicTabbedPaneUI also?

The BasicTabbedPaneUIdoes not have the memory leak because it removes html view element before inserting new one. However, it is faster to set new element rather then removing and inserting it. I have also missed the case that a tab can be inserting between others. I fix it also.

  Could you review the updated fix:
    http://cr.openjdk.java.net/~alexsch/8017284/webrev.01/

  Thanks,
  Alexandr.


On 7/22/14 6:32 PM, Alexander Scherbatiy wrote:

Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8017284
  webrev: http://cr.openjdk.java.net/~alexsch/8017284/webrev.00

  The memory leak in Aqua TabbedPaneUI is fixed.

Thanks,
Alexandr.






--
Best regards, Sergey.

Reply via email to