approved.
-phil.
On 9/10/2014 5:11 AM, Sergey Bylokhov wrote:
Hi, Phil.
It seems both changes are unnecessary:
http://cr.openjdk.java.net/~serb/8055326/webrev.01
On 21.08.2014 22:04, Phil Race wrote:
Was the additional spce on the 2nd line intended here ?
---
old/src/java.desktop/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java
2014-08-21 20:50:04.859532400 +0400
+++
new/src/java.desktop/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java
2014-08-21 20:50:04.663521200 +0400
@@ -166,8 +166,8 @@
retComp =
cont.getFocusTraversalPolicy().getDefaultComponent(cont);
if (retComp != null &&
log.isLoggable(PlatformLogger.Level.FINE)) {
- log.fine("### Transfered focus down-cycle to
" + retComp +
- " in the focus cycle root " + cont);
+ log.fine("### Transferred focus down-cycle
to " + retComp +
+ " in the focus cycle root " + cont);
And I don't see what was so wrong with this, perhaps because I wrote
it :-)
- * so that when the Font2D is GC'd it can also remove the file.
+ * so that when the Font2D is GC'ed it can also remove the
file.
Other than that, looks good.
Some fun new words in there. I particularly liked utilitized and
unclude.
-phil.
On 8/21/2014 10:38 AM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk 9.
The fix was contributed by pavel.ra...@oracle.com
Bug: https://bugs.openjdk.java.net/browse/JDK-8055326
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8055326/webrev.00
