The fix looks good. With best regards. Petr.
On 14 нояб. 2014 г., at 17:59, Anton Nashatyrev <[email protected]> wrote: > Ops, sorry, copied to wrong dir. Please try again: > > http://cr.openjdk.java.net/%7Eanashaty/8059739/9/webrev.01/ > > On 14.11.2014 16:00, Petr Pchelko wrote: >> Hello, Anton. >> >> the link is broken. >> >> with best regards. Petr. >> >> On 14 нояб. 2014 г., at 17:52, Anton Nashatyrev >> <[email protected]> wrote: >> >>> Hello Petr, >>> >>> thanks for your comment! Here is the new version: >>> >>> http://cr.openjdk.java.net/%7Eanashaty/8059739/9/webrev.01/ >>> >>> Thanks! >>> Anton. >>> >>> On 14.11.2014 15:09, Petr Pchelko wrote: >>>> Hello, Anton. >>>> >>>> To get a charset from the DataFlavor object there is a utility method: >>>> DataFlavorUtils.getTextCharset. >>>> Could you please reuse this method, it's more precise than a fallback to >>>> plain unicode. >>>> >>>> With best regards. Petr. >>>> >>>> On 14 нояб. 2014 г., at 16:49, Anton Nashatyrev >>>> <[email protected]> wrote: >>>> >>>>> Hello, >>>>> could you please review the following fix: >>>>> >>>>> fix: http://cr.openjdk.java.net/~anashaty/8059739/9/webrev.00/ >>>>> <http://cr.openjdk.java.net/%7Eanashaty/8059739/9/webrev.00/> >>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8059739 >>>>> >>>>> BasicTransferable should create InputStream for text with respect to >>>>> 'charset' MIME parameter. >>>>> >>>>> Thanks! >>>>> Anton. >
