On 11/24/2014 12:15 PM, Petr Pchelko wrote:
Hello, Alexander.

I bet you do not need to remove the “filter != null” part, because 
Object.equals(null, null) is true and the code will be executed.

    Thank you for the review. Could you review the updated fix:
        http://cr.openjdk.java.net/~alexsch/8031696/webrev.01/

   Thanks,
   Alexandr.


With best regards. Petr.

On Nov 21, 2014, at 7:01 PM, Alexander Scherbatiy 
<[email protected]> wrote:


Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8031696
  webrev: http://cr.openjdk.java.net/~alexsch/8031696/webrev.00

  Setting a new file filter in JFileChooser on Mac OS X starts LoadFilesThread 
from AquaFileSystemModel.
  After the fix JDK-8022398 the file filter changed event is fired even the new 
file filter equals to the old one.
  The fix does not fire the file filter changed event in case the file filter 
has not been changed.

Thanks,
Alexandr.


Reply via email to