Re: [9] Review request for 8130772: Util.hitMnemonics does not work: getSystemMnemonicKeyCodes() returns ALT_MASK rather than VK_ALT

Thu, 09 Jul 2015 05:16:02 -0700 


  The fix looks good to me.

  Thanks,
  Alexandr.

On 7/9/2015 3:11 PM, Sergey Bylokhov wrote:

Looks fine.

On 09.07.15 15:03, Alexey Ivanov wrote:

Hello Swing team,

Could you please review the fix:
    JBS: https://bugs.openjdk.java.net/browse/JDK-8130772
    webrev: http://cr.openjdk.java.net/~aivanov/8130772/jdk9/webrev.00/

Description:
Util.hitMnemonics does not work because the new implementation of Util.getSystemMnemonicKeyCodes adds KeyEvent.ALT_MASK rather than KeyEvent.VK_ALT. 

Fix:
Use KeyEvent.VK_ALT.

Tests that depend on Util.hitMnemonics pass after the fix is applied.

Thanks,
Alexey

Reply via email to