On 9/1/2015 6:15 PM, Sergey Bylokhov wrote:
You are right. The new version of the fix:
http://cr.openjdk.java.net/~serb/8080948/webrev.01

I also have checked that it does not work without the fix for JDK-6418028.

   The fix looks good to me.

   Just split long text like the text on line 114 before the commit.

  Thanks,
  Alexandr.


On 01.09.15 17:05, Alexander Scherbatiy wrote:
On 9/1/2015 4:30 PM, Sergey Bylokhov wrote:
Hello.
Please review the small fix for jdk9.
I hope this is a last issue related to peer and @modules.
The one test is updated to use an accessors, correct @modules tag was
added. + small cleanup.

All other tests were covered by [1],[2].

Bug: https://bugs.openjdk.java.net/browse/JDK-8080948
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8080948/webrev.00

    Is it possible to get rid of the first Standard Test Machinery in
the test too?
    There are long lines in summary that should be split.

    Thanks,
    Alexandr.

[1] https://bugs.openjdk.java.net/browse/JDK-8130839
[2] https://bugs.openjdk.java.net/browse/JDK-8130125






Reply via email to