Re: [9] Review Request for 8075907: The regression-swing case failed as the rollover icons is not correctly shown with the special options"-client -Dswing.defaultlaf=javax.swing.plaf.nimbus.NimbusLookAndFeel"

Fri, 18 Sep 2015 08:36:08 -0700 


  The fix looks good to me.

  Thanks,
  Alexandr.

On 9/17/2015 7:31 PM, Semyon Sadetsky wrote:



On 9/17/2015 6:35 PM, Alexander Scherbatiy wrote:

On 9/17/2015 5:39 PM, Semyon Sadetsky wrote:

Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8075907
webrev: http://cr.openjdk.java.net/~ssadetsky/8075907/webrev.00/
The Nimbus L&F logic to choose the selected button rollover icon had a mistake. The same for the selected button disabled icon.
The state argument is never used in the SynthButtonUI.getIcon(sbstractButton, specificIcon, defaultIcon, state) method if defaultIcon is null. It looks like the suggested change never applies the SynthConstants.SELECTED state for non null defaultIcon.
That's true. Thanks. http://cr.openjdk.java.net/~ssadetsky/8075907/webrev.01/ 

    Thanks,
    Alexandr.


--Semyon

Reply via email to