The fix looks good to me.
Thanks,
Alexandr.
On 11/17/2015 9:01 AM, Rajeev Chamyal wrote:
The fix looks good to me.
Regards,
Rajeev Chamyal
*From:*Avik Niyogi
*Sent:* 17 November 2015 11:16
*To:* Rajeev Chamyal
*Cc:* Alexander Scherbatiy; swing-dev@openjdk.java.net
*Subject:* Re: Review for 8132770: Test
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails in
MacOSX
Hi All,
The bug fix has been updated as per comments.
http://cr.openjdk.java.net/~rchamyal/avik/8132770/webrev.02/
<http://cr.openjdk.java.net/%7Erchamyal/avik/8132770/webrev.02/>
With Regards,
Avik Niyogi
On 16-Nov-2015, at 12:36 pm, Rajeev Chamyal
<rajeev.cham...@oracle.com <mailto:rajeev.cham...@oracle.com>> wrote:
Hello Avik,
In case of test failure also frame should be disposed. Please add
a dispose call before RuntimeException line 190.
Regards,
Rajeev Chamyal
*From:*Avik Niyogi
*Sent:*16 November 2015 12:20
*To:*Rajeev Chamyal
*Cc:*Alexander Scherbatiy; swing-dev@openjdk.java.net
<mailto:swing-dev@openjdk.java.net>
*Subject:*Re: Review for 8132770: Test
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails
in MacOSX
Hi All,
The bug fix has been updated as per the comments.
http://cr.openjdk.java.net/~rchamyal/avik/8132770/webrev.01/
<http://cr.openjdk.java.net/%7Erchamyal/avik/8132770/webrev.01/>
With Regards,
Avik Niyogi
On 13-Nov-2015, at 9:46 am, Avik Niyogi
<avik.niy...@oracle.com <mailto:avik.niy...@oracle.com>> wrote:
Hi Rajeev,
Will fix and create webrev.01 with inputs provided. Also, we
have verified on Mac OS X, Windows and Ubuntu.
With Regards,
Avik Niyogi
On 12-Nov-2015, at 4:52 pm, Rajeev Chamyal
<rajeev.cham...@oracle.com
<mailto:rajeev.cham...@oracle.com>> wrote:
Hello Avik,
1) In the tryLookAndFeel exception handling is skipped. createUI
and other calls should be skipped in case of exception..
2) What all platforms you have tested the bug?
Regards,
Rajeev Chamyal
*From:*Avik Niyogi
*Sent:*04 November 2015 14:51
*To:*Rajeev Chamyal; Alexander
Scherbatiy;swing-dev@openjdk.java.net
<mailto:swing-dev@openjdk.java.net>
*Subject:*Review for 8132770: Test
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails
in MacOSX
Hi All,
Kindly review the fix for JDK9.
*Bug*: https://bugs.openjdk.java.net/browse/JDK-8132770
*Webrev*:
http://cr.openjdk.java.net/~rchamyal/avik/8132770/webrev.00/
<http://cr.openjdk.java.net/%7Erchamyal/avik/8132770/webrev.00/>
*Issue*: Test
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails
in MacOSX where non-eligible Look and Feels are not taken
into account.
*Cause*: TestCase flow for non-Basic JRadioButton UI such
as Aqua, Nimbus and GTK have different focus traversal
track as compared to the rest and require different test
case flow with regards to focus owner.
*Fix*: Modified test case with appropriate deviant test
case for Look and Feels which are not eligible for focus
traversal as expected previously in test file.
With Regards,
Avik Niyogi
