Hi All, Please find updated webrev.01 with inputs from comments below: http://cr.openjdk.java.net/~aniyogi/8139169/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8139169/webrev.01/>
With Regards, Avik Niyogi > On 02-Dec-2015, at 5:16 pm, Rajeev Chamyal <rajeev.cham...@oracle.com> wrote: > > Hello Avik, > > Can you use @requires (os.family == "mac") instead of a method to check the > OS type. > > Regards, > Rajeev Chamyal > > From: Avik Niyogi > Sent: 30 November 2015 17:22 > To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov; > swing-dev@openjdk.java.net > Subject: <Swing Dev> Review Request for 8139169: Action registered for > keyboard shortcut is called twice > > Hi All, > > Kindly review the fix for JDK9. > Bug: > https://bugs.openjdk.java.net/browse/JDK-8139169 > <https://bugs.openjdk.java.net/browse/JDK-8139169> > Webrev: > http://cr.openjdk.java.net/~aniyogi/8139169/webrev.00/ > <http://cr.openjdk.java.net/~aniyogi/8139169/webrev.00/> > > Issue: Swing action with an accelerator like "meta shift COMMA”. > It is put in the component's action map, when it is invoked, the action is > called twice. > Cause: Incorrect implementation within CMenuItem.m > > Fix:Added logic to sense all modifiers including “shift” in CMenuItem which > did not exist before. > > With Regards, > Avik Niyogi
