On 12/7/2015 3:32 PM, Semyon Sadetsky wrote:
On 11/6/2015 4:39 PM, Alexander Scherbatiy wrote:
On 10/28/2015 12:54 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8140527
webrev: http://cr.openjdk.java.net/~ssadetsky/8140527/webrev.00/
Title buttons under Widows Classic LnF got their sizes from the XP
desktop theme in which button width can be bigger than height. The
proposed fix forces title buttons to be square and to fit the frame
title in height.
It looks like the "InternalFrame.titleButtonWidth" property can be
set by a user in UIManager. Should not the updated width value be
used in this case instead of the height property?
Classic Windows style it has some restrictions. Title button should be
square.
If you look on XP style you will see that button proportions are
calculated according the image size as well.
The logic of your fix in the WindowsInternalFrameTitlePane is that
the button width is adjusted only if it is greater than the button height.
Should not it be the similar to the XP style (the width should be
exact as the height or proportionally resized)?
Thanks,
Alexandr.
The test uses internal OSInfo class. The appropriate @modules tag
should be done in this case for the jake build.
http://cr.openjdk.java.net/~ssadetsky/8140527/webrev.01/
Thanks,
Alexandr.
